[wasm] Fixed register allocation for Word32PairShl on arm.

[wasm] Fixed register allocation for Word32PairShl on arm.

The previous register allocation allowed invalid register aliasing in
cases where in the TF graph the node was used for multiple inputs of the
Word32PairShl node.

Additionally I renamed PairLsl to LslPair in the code generation for
consistency.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com

Committed: https://crrev.com/2ddfe43a44193f5295e394f4893e5ee1cc267585
Cr-Commit-Position: refs/heads/master@{#34755}

[titzer, 2016-03-10 10:51:08]

lgtm

https://codereview.chromium.org/1776393004/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/1776393004/diff/1/src/arm/macro-assembler-arm...
src/arm/macro-assembler-arm.cc:1134: if (shift >= 32) {
Do you want to handle the == 32 case specially too?

[ahaas, 2016-03-10 15:57:36]

On 2016/03/10 at 10:51:08, titzer wrote:
> lgtm
> 
>
https://codereview.chromium.org/1776393004/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
> 
>
https://codereview.chromium.org/1776393004/diff/1/src/arm/macro-assembler-arm...
> src/arm/macro-assembler-arm.cc:1134: if (shift >= 32) {
> Do you want to handle the == 32 case specially too?

Done.

I also use rsb + SetCC instead of the explicit comparison, as recommended in
https://codereview.chromium.org/1778893004/diff/1/src/arm/macro-assembler-arm...

[ahaas, 2016-03-10 17:59:39]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-10 17:59:40]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1776393004/#ps20001
(title: "Use rsb wit SetCC instead of an explicit comparison.")

[commit-bot: I haz the power, 2016-03-10 17:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 17:59:44]

This CL has an open dependency (Issue 1778493004 Patch 80001). Please resolve
the dependency and try again.

[ahaas, 2016-03-10 17:59:49]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-03-14 17:03:18]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-14 17:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1776393004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-14 17:03:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776393004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776393004/40001

[commit-bot: I haz the power, 2016-03-14 17:22:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-14 17:24:16]

Description was changed from

==========
[wasm] Fixed register allocation for Word32PairShl on arm.

The previous register allocation allowed invalid register aliasing in
cases where in the TF graph the node was used for multiple inputs of the
Word32PairShl node.

Additionally I renamed PairLsl to LslPair in the code generation for
consistency.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com
==========

to

==========
[wasm] Fixed register allocation for Word32PairShl on arm.

The previous register allocation allowed invalid register aliasing in
cases where in the TF graph the node was used for multiple inputs of the
Word32PairShl node.

Additionally I renamed PairLsl to LslPair in the code generation for
consistency.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com

Committed: https://crrev.com/2ddfe43a44193f5295e394f4893e5ee1cc267585
Cr-Commit-Position: refs/heads/master@{#34755}
==========

[commit-bot: I haz the power, 2016-03-14 17:24:17]

Patchset 3 (id:??) landed as
https://crrev.com/2ddfe43a44193f5295e394f4893e5ee1cc267585
Cr-Commit-Position: refs/heads/master@{#34755}