Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add GetProperty/GetElement to JSReceiver and use it where possible Also move GetProperty with string-name to JSReceiver BUG= Committed: https://crrev.com/7736102034bf6bfad50a98310c752f6524068cfa Cr-Commit-Position: refs/heads/master@{#34596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -150 lines) Patch
M src/api.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.cc View 9 chunks +18 lines, -15 lines 0 comments Download
M src/contexts.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +17 lines, -12 lines 0 comments Download
M src/debug/liveedit.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/debug/liveedit.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M src/i18n.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/json-stringifier.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/log.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/objects.cc View 9 chunks +18 lines, -14 lines 0 comments Download
M src/objects-inl.h View 3 chunks +19 lines, -3 lines 0 comments Download
M src/property-descriptor.cc View 9 chunks +15 lines, -11 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-08 16:54:49 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-08 17:01:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775973002/1
4 years, 9 months ago (2016-03-08 17:02:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 17:29:10 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:30:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7736102034bf6bfad50a98310c752f6524068cfa
Cr-Commit-Position: refs/heads/master@{#34596}

Powered by Google App Engine
This is Rietveld 408576698