src/runtime/runtime-object.cc - Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index c489ab4c5655e174fcd036e5b5099f961eb55680..990ca1359141b865ff17d91234fd1ef5d48328ef 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -1058,7 +1058,8 @@ RUNTIME_FUNCTION(Runtime_InstanceOf) {

Handle<Object> prototype;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

isolate, prototype,

- Object::GetProperty(callable, isolate->factory()->prototype_string()));

+ JSReceiver::GetProperty(Handle<JSReceiver>::cast(callable),

+ isolate->factory()->prototype_string()));

if (!prototype->IsJSReceiver()) {

THROW_NEW_ERROR_RETURN_FAILURE(

isolate,

« no previous file with comments | « src/runtime/runtime-liveedit.cc ('k') | test/cctest/compiler/test-run-jsobjects.cc » ('j') | no next file with comments »