Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/debug/liveedit.h

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.h
diff --git a/src/debug/liveedit.h b/src/debug/liveedit.h
index 47c2844cc990d4efba83ca1d8f74f8e99ed9baa9..67be70e00a298969fc1a93238e11d91b82f2ad71 100644
--- a/src/debug/liveedit.h
+++ b/src/debug/liveedit.h
@@ -252,8 +252,8 @@ class JSArrayBasedStruct {
}
Handle<Object> GetField(int field_position) {
- return Object::GetElement(
- isolate(), array_, field_position).ToHandleChecked();
+ return JSReceiver::GetElement(isolate(), array_, field_position)
+ .ToHandleChecked();
}
int GetSmiValueField(int field_position) {
@@ -333,9 +333,8 @@ class SharedInfoWrapper : public JSArrayBasedStruct<SharedInfoWrapper> {
static bool IsInstance(Handle<JSArray> array) {
if (array->length() != Smi::FromInt(kSize_)) return false;
Handle<Object> element(
- Object::GetElement(array->GetIsolate(),
- array,
- kSharedInfoOffset_).ToHandleChecked());
+ JSReceiver::GetElement(array->GetIsolate(), array, kSharedInfoOffset_)
+ .ToHandleChecked());
if (!element->IsJSValue()) return false;
return Handle<JSValue>::cast(element)->value()->IsSharedFunctionInfo();
}
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698