Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: test/cctest/compiler/test-run-jsobjects.cc

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "test/cctest/compiler/function-tester.h" 5 #include "test/cctest/compiler/function-tester.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 namespace internal { 8 namespace internal {
9 namespace compiler { 9 namespace compiler {
10 10
11 TEST(ArgumentsMapped) { 11 TEST(ArgumentsMapped) {
12 FunctionTester T("(function(a) { return arguments; })"); 12 FunctionTester T("(function(a) { return arguments; })");
13 13
14 Handle<Object> arguments; 14 Handle<Object> arguments;
15 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments); 15 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
16 CHECK(arguments->IsJSObject() && !arguments->IsJSArray()); 16 CHECK(arguments->IsJSObject() && !arguments->IsJSArray());
17 CHECK(JSObject::cast(*arguments)->HasSloppyArgumentsElements()); 17 CHECK(JSObject::cast(*arguments)->HasSloppyArgumentsElements());
18 Handle<String> l = T.isolate->factory()->length_string(); 18 Handle<String> l = T.isolate->factory()->length_string();
19 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked(); 19 Handle<Object> length = Object::GetProperty(arguments, l).ToHandleChecked();
20 CHECK_EQ(4, length->Number()); 20 CHECK_EQ(4, length->Number());
21 } 21 }
22 22
23 23
24 TEST(ArgumentsUnmapped) { 24 TEST(ArgumentsUnmapped) {
25 FunctionTester T("(function(a) { 'use strict'; return arguments; })"); 25 FunctionTester T("(function(a) { 'use strict'; return arguments; })");
26 26
27 Handle<Object> arguments; 27 Handle<Object> arguments;
28 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments); 28 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
29 CHECK(arguments->IsJSObject() && !arguments->IsJSArray()); 29 CHECK(arguments->IsJSObject() && !arguments->IsJSArray());
30 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements()); 30 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
31 Handle<String> l = T.isolate->factory()->length_string(); 31 Handle<String> l = T.isolate->factory()->length_string();
32 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked(); 32 Handle<Object> length = Object::GetProperty(arguments, l).ToHandleChecked();
33 CHECK_EQ(4, length->Number()); 33 CHECK_EQ(4, length->Number());
34 } 34 }
35 35
36 36
37 TEST(ArgumentsRest) { 37 TEST(ArgumentsRest) {
38 FunctionTester T("(function(a, ...args) { return args; })"); 38 FunctionTester T("(function(a, ...args) { return args; })");
39 39
40 Handle<Object> arguments; 40 Handle<Object> arguments;
41 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments); 41 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
42 CHECK(arguments->IsJSObject() && arguments->IsJSArray()); 42 CHECK(arguments->IsJSObject() && arguments->IsJSArray());
43 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements()); 43 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
44 Handle<String> l = T.isolate->factory()->length_string(); 44 Handle<String> l = T.isolate->factory()->length_string();
45 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked(); 45 Handle<Object> length = Object::GetProperty(arguments, l).ToHandleChecked();
46 CHECK_EQ(3, length->Number()); 46 CHECK_EQ(3, length->Number());
47 } 47 }
48 48
49 } // namespace compiler 49 } // namespace compiler
50 } // namespace internal 50 } // namespace internal
51 } // namespace v8 51 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698