Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/public/web/WebPluginContainer.h

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebPluginContainer.h
diff --git a/third_party/WebKit/public/web/WebPluginContainer.h b/third_party/WebKit/public/web/WebPluginContainer.h
index 569d190d7f16d89b876eda3f6fe22b6f68017ebf..47a0d37d5649a9edfa45c006acea52a7dd1d9407 100644
--- a/third_party/WebKit/public/web/WebPluginContainer.h
+++ b/third_party/WebKit/public/web/WebPluginContainer.h
@@ -65,11 +65,8 @@ public:
virtual void invalidateRect(const WebRect&) = 0;
virtual void scrollRect(const WebRect&) = 0;
- // Causes the container to be marked as needing layout, which in turn will cause
- // layoutIfNeeded() to be called on any contained WebPlugin during the container's
- // web view's lifecycle update, and in particular before calling paint() on the
- // WebPlugin.
- virtual void setNeedsLayout() = 0;
+ // Schedules an animation of the WebView that contains the plugin, as well as the plugin.
+ virtual void scheduleAnimation() = 0;
wkorman 2016/03/08 01:38:50 If this is the way a new frame is requested, perha
chrishtr 2016/03/10 19:06:14 In some cases it isn't even running a frame, it's
// Causes the container to report its current geometry via
// WebPlugin::updateGeometry.

Powered by Google App Engine
This is Rietveld 408576698