Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
index 6c4b14d28b26638299534429a8c2b5754c0e609c..e96868f362c65cc290ab212bb79b0316e2c2c4e9 100644
--- a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
@@ -134,8 +134,9 @@ void LayoutEmbeddedObject::layout()
Widget* widget = this->widget();
if (widget) {
+ // TODO(chrishtr): remove this code. It's now called in FrameView::updateStyleAndLayoutIfNeededRecursive.
wkorman 2016/03/08 01:38:50 What blocks removing this?
chrishtr 2016/03/10 19:06:14 I mentioned it in the first patchset, but I left t
if (widget->isPluginView())
- toPluginView(widget)->layoutIfNeeded();
+ toPluginView(widget)->updateAllLifecyclePhases();
} else if (frameView()) {
frameView()->addPartToUpdate(*this);
}

Powered by Google App Engine
This is Rietveld 408576698