third_party/WebKit/public/web/WebPlugin.h - Issue 1774653002: Decouple scheduling animation of webview plugins from layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp ('K') | « third_party/WebKit/Source/web/tests/FakeWebPlugin.h ('k') | third_party/WebKit/public/web/WebPluginContainer.h » ('j') | third_party/WebKit/public/web/WebPluginContainer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebPlugin.h

diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h

index c25bc6c03116134a7b664bcaf746bd894f105ab4..8e6703aa42df7d8da2365fcea7c725768e757e67 100644

--- a/third_party/WebKit/public/web/WebPlugin.h

+++ b/third_party/WebKit/public/web/WebPlugin.h

@@ -103,8 +103,7 @@ public:

virtual bool canProcessDrag() const { return false; }

- // TODO(schenney): Make these pure virtual when chromium changes land

- virtual void layoutIfNeeded() { }

+ virtual void updateAllLifecyclePhases() = 0;

virtual void paint(WebCanvas*, const WebRect&) = 0;

// Coordinates are relative to the containing window.