Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/public/web/WebPluginContainer.h

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 3 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 // Returns the element containing this plugin. 59 // Returns the element containing this plugin.
60 virtual WebElement element() = 0; 60 virtual WebElement element() = 0;
61 61
62 virtual void dispatchProgressEvent(const WebString& type, bool lengthComputa ble, unsigned long long loaded, unsigned long long total, const WebString& url) = 0; 62 virtual void dispatchProgressEvent(const WebString& type, bool lengthComputa ble, unsigned long long loaded, unsigned long long total, const WebString& url) = 0;
63 63
64 virtual void invalidate() = 0; 64 virtual void invalidate() = 0;
65 virtual void invalidateRect(const WebRect&) = 0; 65 virtual void invalidateRect(const WebRect&) = 0;
66 virtual void scrollRect(const WebRect&) = 0; 66 virtual void scrollRect(const WebRect&) = 0;
67 67
68 // Causes the container to be marked as needing layout, which in turn will c ause 68 // Schedules an animation of the WebView that contains the plugin, as well a s the plugin.
69 // layoutIfNeeded() to be called on any contained WebPlugin during the conta iner's 69 virtual void scheduleAnimation() = 0;
wkorman 2016/03/08 01:38:50 If this is the way a new frame is requested, perha
chrishtr 2016/03/10 19:06:14 In some cases it isn't even running a frame, it's
70 // web view's lifecycle update, and in particular before calling paint() on the
71 // WebPlugin.
72 virtual void setNeedsLayout() = 0;
73 70
74 // Causes the container to report its current geometry via 71 // Causes the container to report its current geometry via
75 // WebPlugin::updateGeometry. 72 // WebPlugin::updateGeometry.
76 virtual void reportGeometry() = 0; 73 virtual void reportGeometry() = 0;
77 74
78 // Allow the plugin to pass script objects to the browser. The container 75 // Allow the plugin to pass script objects to the browser. The container
79 // tracks ownership of script objects in order to allow browser references 76 // tracks ownership of script objects in order to allow browser references
80 // to them to be dropped when clearScriptObjects is called. 77 // to them to be dropped when clearScriptObjects is called.
81 virtual void allowScriptObjects() = 0; 78 virtual void allowScriptObjects() = 0;
82 79
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 // WebPluginContainer does *not* take ownership. 141 // WebPluginContainer does *not* take ownership.
145 virtual void setWebLayer(WebLayer*) = 0; 142 virtual void setWebLayer(WebLayer*) = 0;
146 143
147 protected: 144 protected:
148 ~WebPluginContainer() { } 145 ~WebPluginContainer() { }
149 }; 146 };
150 147
151 } // namespace blink 148 } // namespace blink
152 149
153 #endif 150 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698