Replace template_util.h stuff with C++11 <type_traits>

Replace template_util.h stuff with C++11 <type_traits>

BUG=554293
Committed: https://crrev.com/403cb6c9b17343999f09df79b82b56e77bd93839
Cr-Commit-Position: refs/heads/master@{#380369}

[tzik, 2016-03-07 06:49:57]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 06:50:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/20001

[commit-bot: I haz the power, 2016-03-07 06:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 06:58:34]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[tzik, 2016-03-07 07:13:55]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 07:14:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/40001

[commit-bot: I haz the power, 2016-03-07 07:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 07:58:31]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tzik, 2016-03-07 08:00:33]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 08:00:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/60001

[commit-bot: I haz the power, 2016-03-07 08:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 08:42:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tzik, 2016-03-07 12:11:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 12:11:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/80001

[tzik, 2016-03-07 12:13:13]

Description was changed from

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=
==========

to

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=554293
==========

[commit-bot: I haz the power, 2016-03-07 13:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 13:29:19]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tzik, 2016-03-07 14:25:56]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 14:26:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/100001

[tzik, 2016-03-07 16:06:44]

tzik@chromium.org changed reviewers:
+ danakj@chromium.org

[tzik, 2016-03-07 16:06:45]

C++11 <type_traits> seems to be able to replace most of our
base/template_util.h. Can we replace them now? PTAL.

[commit-bot: I haz the power, 2016-03-07 16:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 16:44:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-03-08 00:23:36]

LGTM

https://codereview.chromium.org/1774443002/diff/100001/base/memory/raw_scoped...
File base/memory/raw_scoped_refptr_mismatch_checker.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/memory/raw_scoped...
base/memory/raw_scoped_refptr_mismatch_checker.h:29: #if defined(OS_WIN)
Is this still needed?

https://codereview.chromium.org/1774443002/diff/100001/base/memory/weak_ptr.h
File base/memory/weak_ptr.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/memory/weak_ptr.h...
base/memory/weak_ptr.h:164: typedef std::is_convertible<Derived*,
internal::SupportsWeakPtrBase*>
nit: using instead of typedef

https://codereview.chromium.org/1774443002/diff/100001/base/template_util.h
File base/template_util.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/template_util.h#n...
base/template_util.h:22: typedef char YesType;
Can we move these to callback_internal.h?

https://codereview.chromium.org/1774443002/diff/100001/third_party/crashpad/c...
File third_party/crashpad/crashpad/util/win/process_info.cc (right):

https://codereview.chromium.org/1774443002/diff/100001/third_party/crashpad/c...
third_party/crashpad/crashpad/util/win/process_info.cc:639:
static_assert(std::is_same<decltype(mi.BaseAddress), WinVMAddress>::value,
You might need to add these to
third_party/crashpad/crashpad/compat/non_cxx11_lib/type_traits, and use those
from here instead. Crashpad wants to build with older c++ libs still.

[tzik, 2016-03-08 07:39:01]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 07:39:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/120001

[commit-bot: I haz the power, 2016-03-08 08:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 08:44:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tzik, 2016-03-08 08:50:41]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 08:50:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/140001

[commit-bot: I haz the power, 2016-03-08 12:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 12:24:25]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-03-08 12:59:35]

tzik@chromium.org changed reviewers:
+ scottmg@chromium.org

[tzik, 2016-03-08 13:00:20]

tzik@chromium.org changed reviewers:
+ mdempsky@chromium.org

[tzik, 2016-03-08 13:01:02]

tzik@chromium.org changed reviewers:
+ mmenke@chromium.org

[tzik, 2016-03-08 13:02:56]

tzik@chromium.org changed reviewers:
+ yoshiki@chromium.org

[tzik, 2016-03-08 13:03:46]

tzik@chromium.org changed reviewers:
+ jochen@chromium.org

[tzik, 2016-03-08 13:05:21]

tzik@chromium.org changed reviewers:
+ reillyg@chromium.org

[tzik, 2016-03-08 13:13:51]

Adding owners of each directories. Could you guys take a look to this?

jochen: //chrome, //gin
reillyg: //device, //extensions
yoshiki: //google_apis
mmenke: //net
mdempsky: //sandbox
scottmg: //third_party/crashpad, plus an upstreaming CL:
https://chromium-review.googlesource.com/331150

https://codereview.chromium.org/1774443002/diff/100001/base/memory/raw_scoped...
File base/memory/raw_scoped_refptr_mismatch_checker.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/memory/raw_scoped...
base/memory/raw_scoped_refptr_mismatch_checker.h:29: #if defined(OS_WIN)
On 2016/03/08 00:23:35, danakj wrote:
> Is this still needed?

Removed.

https://codereview.chromium.org/1774443002/diff/100001/base/memory/weak_ptr.h
File base/memory/weak_ptr.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/memory/weak_ptr.h...
base/memory/weak_ptr.h:164: typedef std::is_convertible<Derived*,
internal::SupportsWeakPtrBase*>
On 2016/03/08 00:23:35, danakj wrote:
> nit: using instead of typedef

Done.

https://codereview.chromium.org/1774443002/diff/100001/base/template_util.h
File base/template_util.h (right):

https://codereview.chromium.org/1774443002/diff/100001/base/template_util.h#n...
base/template_util.h:22: typedef char YesType;
On 2016/03/08 00:23:35, danakj wrote:
> Can we move these to callback_internal.h?

Done.

https://codereview.chromium.org/1774443002/diff/100001/third_party/crashpad/c...
File third_party/crashpad/crashpad/util/win/process_info.cc (right):

https://codereview.chromium.org/1774443002/diff/100001/third_party/crashpad/c...
third_party/crashpad/crashpad/util/win/process_info.cc:639:
static_assert(std::is_same<decltype(mi.BaseAddress), WinVMAddress>::value,
On 2016/03/08 00:23:36, danakj wrote:
> You might need to add these to
> third_party/crashpad/crashpad/compat/non_cxx11_lib/type_traits, and use those
> from here instead. Crashpad wants to build with older c++ libs still.

Done.

[tzik, 2016-03-08 13:31:14]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 13:31:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/160001

[mdempsky, 2016-03-08 13:42:18]

lgtm for sandbox/linux

[commit-bot: I haz the power, 2016-03-08 15:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 15:04:47]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-03-08 16:02:31]

lgtm

[scottmg, 2016-03-08 16:44:04]

lgtm

(crashpad changes upstreamed at
https://chromium-review.googlesource.com/c/331287/)

[Reilly Grant (use Gerrit), 2016-03-08 18:12:58]

//device, //extensions lgtm

[mmenke, 2016-03-09 16:57:23]

tzik:  I don't see any net/ changes.  Am I missing something?  Also, I have
no clue how to use that interface to reply on that issue.

On Tue, Mar 8, 2016 at 1:12 PM, <reillyg@chromium.org> wrote:

> //device, //extensions lgtm
>
> https://codereview.chromium.org/1774443002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mmenke, 2016-03-09 17:09:08]

On 2016/03/09 16:57:23, mmenke wrote:
> tzik:  I don't see any net/ changes.  Am I missing something?  Also, I have
> no clue how to use that interface to reply on that issue.
> 
> On Tue, Mar 8, 2016 at 1:12 PM, <mailto:reillyg@chromium.org> wrote:
> 
> > //device, //extensions lgtm
> >
> > https://codereview.chromium.org/1774443002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Oh, I was (repeatedly) going to the googlesource URL, and thinking this was a
review there...Sorry about that.

[mmenke, 2016-03-09 17:12:19]

net/ LGTM

[yoshiki, 2016-03-10 03:42:49]

lgtm google_apis/

[tzik, 2016-03-10 03:45:52]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-03-10 03:45:52]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1774443002/#ps160001
(title: "revert unrelated whitespace change")

[commit-bot: I haz the power, 2016-03-10 03:46:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/160001

[commit-bot: I haz the power, 2016-03-10 05:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 05:41:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-03-10 06:00:52]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-03-10 06:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774443002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774443002/160001

[commit-bot: I haz the power, 2016-03-10 07:17:33]

Description was changed from

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=554293
==========

to

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=554293
==========

[commit-bot: I haz the power, 2016-03-10 07:17:35]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-10 07:19:17]

Description was changed from

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=554293
==========

to

==========
Replace template_util.h stuff with C++11 <type_traits>

BUG=554293

Committed: https://crrev.com/403cb6c9b17343999f09df79b82b56e77bd93839
Cr-Commit-Position: refs/heads/master@{#380369}
==========

[commit-bot: I haz the power, 2016-03-10 07:19:19]

Patchset 9 (id:??) landed as
https://crrev.com/403cb6c9b17343999f09df79b82b56e77bd93839
Cr-Commit-Position: refs/heads/master@{#380369}