Chromium Code Reviews Chromium Code Reviews
Issue 1774443002:
Replace template_util.h stuff with C++11 <type_traits> (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ | 5 #ifndef BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ |
| 6 #define BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ | 6 #define BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ |
| 7 | 7 |
| 8 #include <tuple> | |
| 9 #include <type_traits> | |
| 10 | |
| 8 #include "base/memory/ref_counted.h" | 11 #include "base/memory/ref_counted.h" |
| 9 #include "base/template_util.h" | |
| 10 #include "base/tuple.h" | |
| 11 #include "build/build_config.h" | 12 #include "build/build_config.h" |
| 12 | 13 |
| 13 // It is dangerous to post a task with a T* argument where T is a subtype of | 14 // It is dangerous to post a task with a T* argument where T is a subtype of |
| 14 // RefCounted(Base|ThreadSafeBase), since by the time the parameter is used, the | 15 // RefCounted(Base|ThreadSafeBase), since by the time the parameter is used, the |
| 15 // object may already have been deleted since it was not held with a | 16 // object may already have been deleted since it was not held with a |
| 16 // scoped_refptr. Example: http://crbug.com/27191 | 17 // scoped_refptr. Example: http://crbug.com/27191 |
| 17 // The following set of traits are designed to generate a compile error | 18 // The following set of traits are designed to generate a compile error |
| 18 // whenever this antipattern is attempted. | 19 // whenever this antipattern is attempted. |
| 19 | 20 |
| 20 namespace base { | 21 namespace base { |
| 21 | 22 |
| 22 // This is a base internal implementation file used by task.h and callback.h. | 23 // This is a base internal implementation file used by task.h and callback.h. |
| 23 // Not for public consumption, so we wrap it in namespace internal. | 24 // Not for public consumption, so we wrap it in namespace internal. |
| 24 namespace internal { | 25 namespace internal { |
| 25 | 26 |
| 26 template <typename T> | 27 template <typename T> |
| 27 struct NeedsScopedRefptrButGetsRawPtr { | 28 struct NeedsScopedRefptrButGetsRawPtr { |
| 28 #if defined(OS_WIN) | 29 #if defined(OS_WIN) |
|
danakj
2016/03/08 00:23:35
Is this still needed?
tzik
2016/03/08 13:13:51
Removed.
| |
| 29 enum { | 30 enum { |
| 30 value = base::false_type::value | 31 value = std::false_type::value |
| 31 }; | 32 }; |
| 32 #else | 33 #else |
| 33 enum { | 34 enum { |
| 34 // Human readable translation: you needed to be a scoped_refptr if you are a | 35 // Human readable translation: you needed to be a scoped_refptr if you are a |
| 35 // raw pointer type and are convertible to a RefCounted(Base|ThreadSafeBase) | 36 // raw pointer type and are convertible to a RefCounted(Base|ThreadSafeBase) |
| 36 // type. | 37 // type. |
| 37 value = (is_pointer<T>::value && | 38 value = (std::is_pointer<T>::value && |
| 38 (is_convertible<T, subtle::RefCountedBase*>::value || | 39 (std::is_convertible<T, subtle::RefCountedBase*>::value || |
| 39 is_convertible<T, subtle::RefCountedThreadSafeBase*>::value)) | 40 std::is_convertible<T, subtle::RefCountedThreadSafeBase*>::value)) |
| 40 }; | 41 }; |
| 41 #endif | 42 #endif |
| 42 }; | 43 }; |
| 43 | 44 |
| 44 template <typename Params> | 45 template <typename Params> |
| 45 struct ParamsUseScopedRefptrCorrectly { | 46 struct ParamsUseScopedRefptrCorrectly { |
| 46 enum { value = 0 }; | 47 enum { value = 0 }; |
| 47 }; | 48 }; |
| 48 | 49 |
| 49 template <> | 50 template <> |
| 50 struct ParamsUseScopedRefptrCorrectly<std::tuple<>> { | 51 struct ParamsUseScopedRefptrCorrectly<std::tuple<>> { |
| 51 enum { value = 1 }; | 52 enum { value = 1 }; |
| 52 }; | 53 }; |
| 53 | 54 |
| 54 template <typename Head, typename... Tail> | 55 template <typename Head, typename... Tail> |
| 55 struct ParamsUseScopedRefptrCorrectly<std::tuple<Head, Tail...>> { | 56 struct ParamsUseScopedRefptrCorrectly<std::tuple<Head, Tail...>> { |
| 56 enum { value = !NeedsScopedRefptrButGetsRawPtr<Head>::value && | 57 enum { value = !NeedsScopedRefptrButGetsRawPtr<Head>::value && |
| 57 ParamsUseScopedRefptrCorrectly<std::tuple<Tail...>>::value }; | 58 ParamsUseScopedRefptrCorrectly<std::tuple<Tail...>>::value }; |
| 58 }; | 59 }; |
| 59 | 60 |
| 60 } // namespace internal | 61 } // namespace internal |
| 61 | 62 |
| 62 } // namespace base | 63 } // namespace base |
| 63 | 64 |
| 64 #endif // BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ | 65 #endif // BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ |
| OLD | NEW |
