Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: base/memory/raw_scoped_refptr_mismatch_checker.h

Issue 1774443002: Replace template_util.h stuff with C++11 <type_traits> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert unrelated whitespace change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/callback_internal.h ('k') | base/memory/scoped_ptr.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ 5 #ifndef BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_
6 #define BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ 6 #define BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_
7 7
8 #include <tuple>
9 #include <type_traits>
10
8 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
9 #include "base/template_util.h"
10 #include "base/tuple.h"
11 #include "build/build_config.h"
12 12
13 // It is dangerous to post a task with a T* argument where T is a subtype of 13 // It is dangerous to post a task with a T* argument where T is a subtype of
14 // RefCounted(Base|ThreadSafeBase), since by the time the parameter is used, the 14 // RefCounted(Base|ThreadSafeBase), since by the time the parameter is used, the
15 // object may already have been deleted since it was not held with a 15 // object may already have been deleted since it was not held with a
16 // scoped_refptr. Example: http://crbug.com/27191 16 // scoped_refptr. Example: http://crbug.com/27191
17 // The following set of traits are designed to generate a compile error 17 // The following set of traits are designed to generate a compile error
18 // whenever this antipattern is attempted. 18 // whenever this antipattern is attempted.
19 19
20 namespace base { 20 namespace base {
21 21
22 // This is a base internal implementation file used by task.h and callback.h. 22 // This is a base internal implementation file used by task.h and callback.h.
23 // Not for public consumption, so we wrap it in namespace internal. 23 // Not for public consumption, so we wrap it in namespace internal.
24 namespace internal { 24 namespace internal {
25 25
26 template <typename T> 26 template <typename T>
27 struct NeedsScopedRefptrButGetsRawPtr { 27 struct NeedsScopedRefptrButGetsRawPtr {
28 #if defined(OS_WIN)
29 enum {
30 value = base::false_type::value
31 };
32 #else
33 enum { 28 enum {
34 // Human readable translation: you needed to be a scoped_refptr if you are a 29 // Human readable translation: you needed to be a scoped_refptr if you are a
35 // raw pointer type and are convertible to a RefCounted(Base|ThreadSafeBase) 30 // raw pointer type and are convertible to a RefCounted(Base|ThreadSafeBase)
36 // type. 31 // type.
37 value = (is_pointer<T>::value && 32 value = (std::is_pointer<T>::value &&
38 (is_convertible<T, subtle::RefCountedBase*>::value || 33 (std::is_convertible<T, subtle::RefCountedBase*>::value ||
39 is_convertible<T, subtle::RefCountedThreadSafeBase*>::value)) 34 std::is_convertible<T, subtle::RefCountedThreadSafeBase*>::value))
40 }; 35 };
41 #endif
42 }; 36 };
43 37
44 template <typename Params> 38 template <typename Params>
45 struct ParamsUseScopedRefptrCorrectly { 39 struct ParamsUseScopedRefptrCorrectly {
46 enum { value = 0 }; 40 enum { value = 0 };
47 }; 41 };
48 42
49 template <> 43 template <>
50 struct ParamsUseScopedRefptrCorrectly<std::tuple<>> { 44 struct ParamsUseScopedRefptrCorrectly<std::tuple<>> {
51 enum { value = 1 }; 45 enum { value = 1 };
52 }; 46 };
53 47
54 template <typename Head, typename... Tail> 48 template <typename Head, typename... Tail>
55 struct ParamsUseScopedRefptrCorrectly<std::tuple<Head, Tail...>> { 49 struct ParamsUseScopedRefptrCorrectly<std::tuple<Head, Tail...>> {
56 enum { value = !NeedsScopedRefptrButGetsRawPtr<Head>::value && 50 enum { value = !NeedsScopedRefptrButGetsRawPtr<Head>::value &&
57 ParamsUseScopedRefptrCorrectly<std::tuple<Tail...>>::value }; 51 ParamsUseScopedRefptrCorrectly<std::tuple<Tail...>>::value };
58 }; 52 };
59 53
60 } // namespace internal 54 } // namespace internal
61 55
62 } // namespace base 56 } // namespace base
63 57
64 #endif // BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_ 58 #endif // BASE_MEMORY_RAW_SCOPED_REFPTR_MISMATCH_CHECKER_H_
OLDNEW
« no previous file with comments | « base/callback_internal.h ('k') | base/memory/scoped_ptr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698