Use the crrev recipe module to fetch commit hashes.

Use the crrev recipe module to fetch commit hashes.

BUG=585563
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299254

[qyearsley, 2016-03-07 23:32:52]

qyearsley@chromium.org changed reviewers:
+ robertocn@chromium.org

[qyearsley, 2016-03-07 23:32:53]

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/auto_bisect/__init__.py (right):

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/auto_bisect/__init__.py:26: ]
The change to this file should just be sorting and adding "crrev".

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/auto_bisect/bisector.py:156: raise
Note: this will make up to 3 requests to crrev and if it fails 3 times, then we
conclude that we got a bad input rev.

[qyearsley, 2016-03-07 23:39:40]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 23:39:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773933002/20001

[commit-bot: I haz the power, 2016-03-07 23:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:44:20]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-03-11 18:23:47]

On 2016/03/07 at 23:44:20, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

Roberto, Prasad, could you take a look at this when you have time?

[RobertoCN, 2016-03-11 18:40:23]

LGTM with question.

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
File scripts/slave/recipes/bisect.py (right):

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/bisect.py:267: commit_pos = 'refs/heads/master@{#%s}' %
commit_pos_number
Question: what's the difference between this string templating and
commit_postion.construct() used in bisector.py?

[prasadv, 2016-03-11 18:52:06]

prasadv@chromium.org changed reviewers:
+ prasadv@chromium.org

[prasadv, 2016-03-11 18:52:07]

lgtm

[qyearsley, 2016-03-11 18:57:50]

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
File scripts/slave/recipes/bisect.py (right):

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/bisect.py:267: commit_pos = 'refs/heads/master@{#%s}' %
commit_pos_number
On 2016/03/11 at 18:40:23, RobertoCN wrote:
> Question: what's the difference between this string templating and
commit_postion.construct() used in bisector.py?

There shouldn't be any difference -- and I think it's probably better to use
commit_position.construct. Will upload another patch to do this.

[qyearsley, 2016-03-11 20:07:02]

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
File scripts/slave/recipes/bisect.py (right):

https://codereview.chromium.org/1773933002/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/bisect.py:267: commit_pos = 'refs/heads/master@{#%s}' %
commit_pos_number
On 2016/03/11 at 18:57:50, qyearsley wrote:
> On 2016/03/11 at 18:40:23, RobertoCN wrote:
> > Question: what's the difference between this string templating and
commit_postion.construct() used in bisector.py?
> 
> There shouldn't be any difference -- and I think it's probably better to use
commit_position.construct. Will upload another patch to do this.

On the other hand, now that I'm trying to use commit_position.construct, I'm
getting the following error when running the recipe simulation tests:

  File ".../recipes/bisect.py", line 268, in _get_step_data_for_revision
    commit_pos = api.m.commit_position.construct(
AttributeError: 'RecipeTestApi' object has no attribute 'construct'

I'm not sure what's wrong here :-/

Maybe the original way is good anyway, since it's more explicit?

[qyearsley, 2016-03-11 22:50:30]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-03-11 22:50:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773933002/20001

[commit-bot: I haz the power, 2016-03-11 22:55:00]

Description was changed from

==========
Use the crrev recipe module to fetch commit hashes.

BUG=585563
==========

to

==========
Use the crrev recipe module to fetch commit hashes.

BUG=585563

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299254
==========

[commit-bot: I haz the power, 2016-03-11 22:55:01]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299254

[qyearsley, 2016-03-14 17:30:44]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1801843002/ by qyearsley@chromium.org.

The reason for reverting is: Causing failures e.g.:

https://build.chromium.org/p/tryserver.chromium.perf/builders/android_fyi_per....