scripts/slave/recipe_modules/auto_bisect/bisector.py - Issue 1773933002: Use the crrev recipe module to fetch commit hashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1773933002: Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Update other bisect & bisect_test recipe expectations Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/auto_bisect/__init__.py ('K') | « scripts/slave/recipe_modules/auto_bisect/__init__.py ('k') | scripts/slave/recipe_modules/auto_bisect/example.py » ('j') | scripts/slave/recipes/bisect.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/auto_bisect/bisector.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py

index 34bce59c9899cf08a8863c06d36f69d7bf015579..14a6dd7587700d64fd2f3a3292dae7d1b9108b5f 100644

--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py

+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py

@@ -147,7 +147,13 @@ class Bisector(object):

if self._is_sha1(rev): # pragma: no cover

return rev

if rev.isdigit():

- return self._api.m.commit_position.chromium_hash_from_commit_position(rev)

+ commit_position = self._api.m.commit_position.construct(

+ branch='refs/heads/master', value=rev)

+ try:

+ return self._api.m.crrev.to_commit_hash(commit_position)

+ except self.api.m.step.StepFailure: # pragma: no cover

+ self.surface_result('BAD_REV')

+ raise

qyearsley 2016/03/07 23:32:53 Note: this will make up to 3 requests to crrev and

self.surface_result('BAD_REV') # pragma: no cover

raise self.api.m.step.StepFailure(

'Invalid input revision: %r' % (rev,)) # pragma: no cover