scripts/slave/recipes/bisect.py - Issue 1773933002: Use the crrev recipe module to fetch commit hashes.

Unified Diff: scripts/slave/recipes/bisect.py

Issue 1773933002: Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Update other bisect & bisect_test recipe expectations Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/auto_bisect/bisector.py ('K') | « scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index 17e0611425510849effda3ec97802fe57d265871..d11729ec2cec6f25ad97ebe44169d9e60fbaa9fd 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -258,15 +258,17 @@ def _get_revision_range_step_data(api, range_data):

def _get_step_data_for_revision(api, revision_data, skip_results=False):

"""Generator that produces step patches for fake results."""

- commit_pos = revision_data['commit_pos']

+ commit_pos_number = revision_data['commit_pos']

commit_hash = revision_data['hash']

test_results = revision_data['test_results']

if 'refrange' in revision_data:

parent_step = 'Resolving reference range.'

- step_name = parent_step + 'resolving commit_pos ' + commit_pos

- yield api.step_data(step_name, stdout=api.raw_io.output('hash:' +

- commit_hash))

+ commit_pos = 'refs/heads/master@{#%s}' % commit_pos_number

RobertoCN 2016/03/11 18:40:23 Question: what's the difference between this strin

qyearsley 2016/03/11 18:57:50 There shouldn't be any difference -- and I think i

qyearsley 2016/03/11 20:07:02 File ".../recipes/bisect.py", line 268, in _get_st

+ step_name = parent_step + 'crrev get commit hash for ' + commit_pos

+ yield api.step_data(

+ step_name,

+ stdout=api.json.output({'git_sha': commit_hash}))

if not skip_results:

step_name = ('Waiting for chromium@%s.gsutil '