scripts/slave/recipes/bisect_test/example_bisect_results.py - Issue 1773933002: Use the crrev recipe module to fetch commit hashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisect_test/example_bisect_results.py

Issue 1773933002: Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Update other bisect & bisect_test recipe expectations Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/bisect.py ('K') | « scripts/slave/recipes/bisect.expected/broken_good_revision_test.json ('k') | scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisect_test/example_bisect_results.py

diff --git a/scripts/slave/recipes/bisect_test/example_bisect_results.py b/scripts/slave/recipes/bisect_test/example_bisect_results.py

index 09f625fc852567d27319579349b56b3d21c172aa..efda0a2926e573ebc75fa6a73824c18bc03b947c 100644

--- a/scripts/slave/recipes/bisect_test/example_bisect_results.py

+++ b/scripts/slave/recipes/bisect_test/example_bisect_results.py

@@ -90,9 +90,11 @@ def set_attributes(target, attributes):

def add_revision_mapping(api, test, pos, sha):

- step_name = 'Resolving reference range.resolving commit_pos ' + pos

- stdout = api.raw_io.output('hash:' + sha)

+ step_name = ('Resolving reference range.crrev get commit hash for ' +

+ 'refs/heads/master@{#%s}' % pos)

+ stdout = api.json.output({'git_sha': sha})

test += api.step_data(step_name, stdout=stdout)

step_name = 'Resolving reference range.resolving hash ' + sha

pos = 'refs/heads/master@{#%s}' % pos

stdout = api.raw_io.output(pos)