Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1773633003: [DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection (Closed)

Created:
4 years, 9 months ago by Kunihiko Sakamoto
Modified:
4 years, 6 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection - Logs LayoutAnalyzer trace event in blink.user_timing category (needed for WPT testing) - Adds page and screen heights information to the trace event - FontFaceSet::hasBlankText() checks there's any pending webfont in block period && >200 characters laid out Design doc: https://docs.google.com/document/d/1BR94tJdZLsin5poeet0XoTW60M0SjvOJQttKT-JK8HI/edit?usp=sharing

Patch Set 1 #

Patch Set 2 : Add heights and webfont info #

Patch Set 3 : crash fix? #

Patch Set 4 : Wait only webfonts with >=100 characters painted #

Patch Set 5 : Count characters with willUseFontData() #

Patch Set 6 : add frame ID #

Patch Set 7 : Increase webfont threshold #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontFace.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSource.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 2 3 4 5 6 7 8 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontSelector.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
paulirish
https://codereview.chromium.org/1773633003/diff/160001/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1773633003/diff/160001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode843 third_party/WebKit/Source/core/frame/FrameView.cpp:843: value->setInteger("contentsHeightBefore", contentsSize().height()); Are you submitting a CL for these ...
4 years, 7 months ago (2016-04-29 02:41:51 UTC) #3
Kunihiko Sakamoto
4 years, 7 months ago (2016-05-09 07:33:42 UTC) #4
https://codereview.chromium.org/1773633003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1773633003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:843:
value->setInteger("contentsHeightBefore", contentsSize().height());
On 2016/04/29 02:41:51, paulirish wrote:
> Are you submitting a CL for these non-font counter values?

Sorry for the delay, just sent out https://codereview.chromium.org/1957193002/
for review.

Powered by Google App Engine
This is Rietveld 408576698