third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp - Issue 1773633003: [DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

Issue 1773633003: [DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h ('k') | third_party/WebKit/Source/core/css/FontFace.h » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

index b542e535169b0c263c4105f8a3c3defd29327e48..56a59ef24e4a8ed23a3914172d06f1f0e82c820f 100644

--- a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

@@ -133,12 +133,10 @@ PassRefPtr<FontData> CSSSegmentedFontFace::getFontData(const FontDescription& fo

return nullptr;

}

-void CSSSegmentedFontFace::willUseFontData(const FontDescription& fontDescription, UChar32 character)

+void CSSSegmentedFontFace::willUseFontData(const FontDescription& fontDescription, const String& text)

{

for (FontFaceList::reverse_iterator it = m_fontFaces.rbegin(); it != m_fontFaces.rend(); ++it) {

- if ((*it)->loadStatus() != FontFace::Unloaded)

- break;

- if ((*it)->cssFontFace()->maybeScheduleFontLoad(fontDescription, character))

+ if ((*it)->willUseFontData(fontDescription, text))

break;

}