third_party/WebKit/Source/platform/fonts/Font.cpp - Issue 1773633003: [DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Font.cpp

Issue 1773633003: [DO NOT COMMIT] Trace events for layout-based First Meaningful Paint detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/platform/fonts/Font.h ('k') | third_party/WebKit/Source/platform/fonts/FontSelector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/Font.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/Font.cpp b/third_party/WebKit/Source/platform/fonts/Font.cpp

index 094bfebbf39e69345ef7fd0f02338c4c10a0ff84..fcfdd472773a76be93923020df85b876c563e493 100644

--- a/third_party/WebKit/Source/platform/fonts/Font.cpp

+++ b/third_party/WebKit/Source/platform/fonts/Font.cpp

@@ -470,11 +470,11 @@ bool Font::computeCanShapeWordByWord() const

return !platformData.hasSpaceInLigaturesOrKerning(features);

};

-void Font::willUseFontData(UChar32 character) const

+void Font::willUseFontData(const String& text) const

{

const FontFamily& family = getFontDescription().family();

if (m_fontFallbackList && m_fontFallbackList->getFontSelector() && !family.familyIsEmpty())

- m_fontFallbackList->getFontSelector()->willUseFontData(getFontDescription(), family.family(), character);

+ m_fontFallbackList->getFontSelector()->willUseFontData(getFontDescription(), family.family(), text);

}

static inline GlyphData glyphDataForNonCJKCharacterWithGlyphOrientation(UChar32 character, bool isUpright, GlyphData& data, unsigned pageNumber)