Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1957193002: Add contents / viewport heights to LayoutAnalyzer trace event (Closed)

Created:
4 years, 7 months ago by Kunihiko Sakamoto
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, kouhei (in TOK), paulirish
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 Committed: https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61 Cr-Commit-Position: refs/heads/master@{#392535}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : line wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Kunihiko Sakamoto
PTAL
4 years, 7 months ago (2016-05-09 07:32:30 UTC) #5
benjhayden
one nit then lgtm https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode856 third_party/WebKit/Source/core/frame/FrameView.cpp:856: TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", "contentsHeightBeforeLayout", layoutView()->documentRect().height()); newline ...
4 years, 7 months ago (2016-05-09 20:00:51 UTC) #6
Kunihiko Sakamoto
+kinuko for OWNER's review Thanks. https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode856 third_party/WebKit/Source/core/frame/FrameView.cpp:856: TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", "contentsHeightBeforeLayout", layoutView()->documentRect().height()); ...
4 years, 7 months ago (2016-05-10 02:12:30 UTC) #8
kouhei (in TOK)
owner lgtm
4 years, 7 months ago (2016-05-10 02:13:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957193002/60001
4 years, 7 months ago (2016-05-10 02:14:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-10 03:24:51 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 03:25:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61
Cr-Commit-Position: refs/heads/master@{#392535}

Powered by Google App Engine
This is Rietveld 408576698