Add contents / viewport heights to LayoutAnalyzer trace event

Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790
Committed: https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61
Cr-Commit-Position: refs/heads/master@{#392535}

[Kunihiko Sakamoto, 2016-05-09 06:00:01]

Patchset #2 (id:20001) has been deleted

[Kunihiko Sakamoto, 2016-05-09 06:00:13]

Patchset #1 (id:1) has been deleted

[Kunihiko Sakamoto, 2016-05-09 06:34:27]

Description was changed from

==========
Trace event for contents height

BUG=
==========

to

==========
Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790
==========

[Kunihiko Sakamoto, 2016-05-09 07:32:30]

ksakamoto@chromium.org changed reviewers:
+ benjhayden@chromium.org

[Kunihiko Sakamoto, 2016-05-09 07:32:30]

PTAL

[benjhayden, 2016-05-09 20:00:51]

one nit then lgtm

https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:856:
TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout",
"contentsHeightBeforeLayout", layoutView()->documentRect().height());
newline before "contentsHeightBeforeLayout", please.

[Kunihiko Sakamoto, 2016-05-10 02:12:29]

ksakamoto@chromium.org changed reviewers:
+ kinuko@chromium.org

[Kunihiko Sakamoto, 2016-05-10 02:12:30]

+kinuko for OWNER's review

Thanks.

https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:856:
TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout",
"contentsHeightBeforeLayout", layoutView()->documentRect().height());
On 2016/05/09 20:00:50, benjhayden_chromium wrote:
> newline before "contentsHeightBeforeLayout", please.

Done.

[kouhei (in TOK), 2016-05-10 02:13:09]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2016-05-10 02:13:10]

owner lgtm

[Kunihiko Sakamoto, 2016-05-10 02:13:52]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-05-10 02:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjhayden@chromium.org
Link to the patchset: https://codereview.chromium.org/1957193002/#ps60001
(title: "line wrap")

[commit-bot: I haz the power, 2016-05-10 02:14:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957193002/60001

[commit-bot: I haz the power, 2016-05-10 03:24:50]

Description was changed from

==========
Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790
==========

to

==========
Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790
==========

[commit-bot: I haz the power, 2016-05-10 03:24:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-10 03:25:44]

Description was changed from

==========
Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790
==========

to

==========
Add contents / viewport heights to LayoutAnalyzer trace event

This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.

BUG=507790

Committed: https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61
Cr-Commit-Position: refs/heads/master@{#392535}
==========

[commit-bot: I haz the power, 2016-05-10 03:25:45]

Patchset 2 (id:??) landed as
https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61
Cr-Commit-Position: refs/heads/master@{#392535}