|
|
Created:
4 years, 7 months ago by Kunihiko Sakamoto Modified:
4 years, 7 months ago CC:
blink-reviews, chromium-reviews, kouhei (in TOK), paulirish Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd contents / viewport heights to LayoutAnalyzer trace event
This patch adds the followings to LayoutAnalyzer trace event:
- contents height before and after layout
- frame's viewport height
These will be used to compute trace-based First Meaningful Paint.
BUG=507790
Committed: https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61
Cr-Commit-Position: refs/heads/master@{#392535}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : line wrap #Messages
Total messages: 17 (10 generated)
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Trace event for contents height BUG= ========== to ========== Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 ==========
ksakamoto@chromium.org changed reviewers: + benjhayden@chromium.org
PTAL
one nit then lgtm https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/FrameView.cpp:856: TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", "contentsHeightBeforeLayout", layoutView()->documentRect().height()); newline before "contentsHeightBeforeLayout", please.
ksakamoto@chromium.org changed reviewers: + kinuko@chromium.org
+kinuko for OWNER's review Thanks. https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1957193002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/FrameView.cpp:856: TRACE_EVENT_BEGIN1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", "contentsHeightBeforeLayout", layoutView()->documentRect().height()); On 2016/05/09 20:00:50, benjhayden_chromium wrote: > newline before "contentsHeightBeforeLayout", please. Done.
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
owner lgtm
The CQ bit was checked by ksakamoto@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from benjhayden@chromium.org Link to the patchset: https://codereview.chromium.org/1957193002/#ps60001 (title: "line wrap")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957193002/60001
Message was sent while issue was closed.
Description was changed from ========== Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 ========== to ========== Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 ========== to ========== Add contents / viewport heights to LayoutAnalyzer trace event This patch adds the followings to LayoutAnalyzer trace event: - contents height before and after layout - frame's viewport height These will be used to compute trace-based First Meaningful Paint. BUG=507790 Committed: https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61 Cr-Commit-Position: refs/heads/master@{#392535} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ed5e957c0eb3dc850e20a950af1142eede01ad61 Cr-Commit-Position: refs/heads/master@{#392535} |