Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1773443002: Revert of Simplify TypingCommand::insertText (Closed)

Created:
4 years, 9 months ago by yoichio
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify TypingCommand::insertText Revert the CL https://codereview.chromium.org/1753703005 because of the regression. git revert caused conflict so I manually reverted the CL. BUG=591978 Committed: https://crrev.com/c3d1650c1e7512e3e7ba70c8eda1dfa88ffc4c2c Cr-Commit-Position: refs/heads/master@{#379531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yoichio
4 years, 9 months ago (2016-03-07 07:29:45 UTC) #3
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-07 08:28:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773443002/1
4 years, 9 months ago (2016-03-07 08:29:02 UTC) #6
yosin_UTC9
What regression did we have?
4 years, 9 months ago (2016-03-07 08:30:15 UTC) #7
yoichio
On 2016/03/07 at 08:30:15, yosin wrote: > What regression did we have? In gmail, enabling ...
4 years, 9 months ago (2016-03-07 09:20:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 10:20:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 10:21:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3d1650c1e7512e3e7ba70c8eda1dfa88ffc4c2c
Cr-Commit-Position: refs/heads/master@{#379531}

Powered by Google App Engine
This is Rietveld 408576698