Simplify TypingCommand::insertText

Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before TypingCommand::insertText.

BUG=

Committed: https://crrev.com/48f364c944440645164842a30354541792a6ef19
Cr-Commit-Position: refs/heads/master@{#378984}

[yoichio, 2016-03-03 04:37:22]

Patchset #1 (id:1) has been deleted

[yoichio, 2016-03-03 04:37:27]

Patchset #1 (id:20001) has been deleted

[yoichio, 2016-03-03 05:03:32]

Description was changed from

==========
ref editor::command selection

BUG=
==========

to

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refer frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before.

BUG=
==========

[yoichio, 2016-03-03 05:03:41]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2016-03-03 06:14:20]

https://codereview.chromium.org/1753703005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/1753703005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:178: String
newText = dispatchBeforeTextInsertedEvent(text, currentSelection, composition ==
TextCompositionUpdate);
|compositionType| is better than |composition|, since |composition| means a
thing of composed.
Let's rename |composition| to |compositionType|.

[yoichio, 2016-03-03 06:55:49]

Description was changed from

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refer frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before.

BUG=
==========

to

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before.

BUG=
==========

[yoichio, 2016-03-03 06:56:05]

Description was changed from

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before.

BUG=
==========

to

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before
TypingCommand::insertText.

BUG=
==========

[yoichio, 2016-03-03 07:13:08]

On 2016/03/03 at 06:14:20, yosin wrote:
>
https://codereview.chromium.org/1753703005/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
(right):
> 
>
https://codereview.chromium.org/1753703005/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:178: String
newText = dispatchBeforeTextInsertedEvent(text, currentSelection, composition ==
TextCompositionUpdate);
> |compositionType| is better than |composition|, since |composition| means a
thing of composed.
> Let's rename |composition| to |compositionType|.

[yosin_UTC9, 2016-03-03 07:36:52]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-03-03 07:36:53]

lgtm

[commit-bot: I haz the power, 2016-03-03 07:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753703005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753703005/60001

[commit-bot: I haz the power, 2016-03-03 08:45:14]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-03-03 08:46:30]

Description was changed from

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before
TypingCommand::insertText.

BUG=
==========

to

==========
Simplify TypingCommand::insertText

TypingCommand::insertText needs VisibleSelection to insert.
It is |selectionForInsertion|.

TypingCommand::insertText creates TypingCommand, or |command| and:
command->setEndingSelection(selectionForInsertion);
command->Apply();
command->setEndingSelection(frameSelection->selection());

However, TypingCommand refers frameselection its inside.
Thus just insert |selectionForInsertion| to frameSelection before
TypingCommand::insertText.

BUG=

Committed: https://crrev.com/48f364c944440645164842a30354541792a6ef19
Cr-Commit-Position: refs/heads/master@{#378984}
==========

[commit-bot: I haz the power, 2016-03-03 08:46:31]

Patchset 2 (id:??) landed as
https://crrev.com/48f364c944440645164842a30354541792a6ef19
Cr-Commit-Position: refs/heads/master@{#378984}