Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 1773443002: Revert of Simplify TypingCommand::insertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 98bdea11ce763d026f73c8f0abc314390981ef24..4c303e69beb3a25b6c93fc49f401d54d2133fb68 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -796,9 +796,10 @@ bool Editor::insertTextWithoutSendingTextEvent(const String& text, bool selectIn
if (!selection.isContentEditable())
return false;
- frame().selection().setSelection(selection);
+ spellChecker().updateMarkersForWordsAffectedByEditing(isSpaceOrNewline(text[0]));
+
// Insert the text
- TypingCommand::insertText(*selection.start().document(), text,
+ TypingCommand::insertText(*selection.start().document(), text, selection,
selectInsertedText ? TypingCommand::SelectInsertedText : 0,
triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698