third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h - Issue 1773443002: Revert of Simplify TypingCommand::insertText

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h

Issue 1773443002: Revert of Simplify TypingCommand::insertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 22 matching lines...) Expand all Loading...
33 namespace blink {	33 namespace blink {

34	34

35 class Document;	35 class Document;

36	36

37 class TextInsertionBaseCommand : public CompositeEditCommand {	37 class TextInsertionBaseCommand : public CompositeEditCommand {

38 public:	38 public:

39 ~TextInsertionBaseCommand() override { }	39 ~TextInsertionBaseCommand() override { }

40	40

41 protected:	41 protected:

42 explicit TextInsertionBaseCommand(Document&);	42 explicit TextInsertionBaseCommand(Document&);

	43 static void applyTextInsertionCommand(LocalFrame*, PassRefPtrWillBeRawPtr<Te xtInsertionBaseCommand>, const VisibleSelection& selectionForInsertion, const Vi sibleSelection& endingSelection);

43 };	44 };

44	45

45 } // namespace blink	46 } // namespace blink

46	47

47 #endif	48 #endif

OLD	NEW