Add frameId to contextMenus.onClicked / onclick.

Add frameId to contextMenus.onClicked / onclick.

BUG=592250
TEST=./browser_tests --gtest_filter=ExtensionContextMenuBrowserTest.ClickInFrame:ExtensionContextMenuBrowserLazyTest.EventPage

Committed: https://crrev.com/cbe35bac4f296de200b2821d8406d921b83956ba
Cr-Commit-Position: refs/heads/master@{#380284}

[robwu, 2016-03-06 20:12:44]

rob@robwu.nl changed reviewers:
+ benwells@chromium.org

[benwells, 2016-03-09 03:20:36]

benwells@chromium.org changed reviewers:
+ asargent@chromium.org

[benwells, 2016-03-09 03:20:36]

Sorry about the delay, I was memory sheriff for the past few days.

I just had a look at this and decided I should punt this to asargent@, who is
probably better equiped for the review. Antony, punt it back if you want.

[asargent_no_longer_on_chrome, 2016-03-09 22:26:01]

lgtm

[robwu, 2016-03-09 22:34:49]

rob@robwu.nl changed reviewers:
+ sky@chromium.org
- benwells@chromium.org

[robwu, 2016-03-09 22:34:50]

sky: Could you rubberstamp l-g-t-m the next files:
- chrome/browser/renderer_context_menu/render_view_context_menu.cc
- chrome/browser/ui/app_list/extension_app_context_menu.cc
- chrome/browser/ui/ash/launcher/launcher_context_menu.cc

[sky, 2016-03-09 22:44:40]

https://codereview.chromium.org/1772513002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/extension_app_context_menu.cc (right):

https://codereview.chromium.org/1772513002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/extension_app_context_menu.cc:240:
extension_menu_items_->ExecuteCommand(command_id, nullptr, nullptr,
Don't extensions have an associated RFH?

[robwu, 2016-03-09 22:52:20]

https://codereview.chromium.org/1772513002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/extension_app_context_menu.cc (right):

https://codereview.chromium.org/1772513002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/extension_app_context_menu.cc:240:
extension_menu_items_->ExecuteCommand(command_id, nullptr, nullptr,
On 2016/03/09 22:44:40, sky wrote:
> Don't extensions have an associated RFH?

It seems that this context menu item is context-less (at the next line,
ContextMenuParams()'s default constructor is used). This context menu is shown
at chrome://apps, so not attributing the context menu entry to the tab and/or
frame looks OK to me.

[sky, 2016-03-09 22:55:03]

Ok, LGTM

[robwu, 2016-03-09 22:59:38]

The CQ bit was checked by rob@robwu.nl

[commit-bot: I haz the power, 2016-03-09 22:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772513002/1

[commit-bot: I haz the power, 2016-03-10 01:20:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 01:22:21]

Description was changed from

==========
Add frameId to contextMenus.onClicked / onclick.

BUG=592250
TEST=./browser_tests
--gtest_filter=ExtensionContextMenuBrowserTest.ClickInFrame:ExtensionContextMenuBrowserLazyTest.EventPage
==========

to

==========
Add frameId to contextMenus.onClicked / onclick.

BUG=592250
TEST=./browser_tests
--gtest_filter=ExtensionContextMenuBrowserTest.ClickInFrame:ExtensionContextMenuBrowserLazyTest.EventPage

Committed: https://crrev.com/cbe35bac4f296de200b2821d8406d921b83956ba
Cr-Commit-Position: refs/heads/master@{#380284}
==========

[commit-bot: I haz the power, 2016-03-10 01:22:22]

Patchset 1 (id:??) landed as
https://crrev.com/cbe35bac4f296de200b2821d8406d921b83956ba
Cr-Commit-Position: refs/heads/master@{#380284}