Add frameId to contextMenus.onClicked / onclick.

chrome/browser/ui/app_list/extension_app_context_menu.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_context_menu.h"
 
 #include "chrome/browser/extensions/context_menu_matcher.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/menu_manager.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
@@ skipping 219 matching lines @@
                         ? extensions::LAUNCH_TYPE_REGULAR
                         : extensions::LAUNCH_TYPE_WINDOW;
     }
     controller()->SetExtensionLaunchType(profile(), app_id(), launch_type);
   } else if (command_id == OPTIONS) {
     controller()->ShowOptionsPage(profile(), app_id());
   } else if (command_id == UNINSTALL) {
     controller()->UninstallApp(profile(), app_id());
   } else if (extensions::ContextMenuMatcher::IsExtensionsCustomCommandId(
                  command_id)) {
-    extension_menu_items_->ExecuteCommand(command_id, nullptr,
+    extension_menu_items_->ExecuteCommand(command_id, nullptr, nullptr,

[sky, 2016/03/09 22:44:40]

Don't extensions have an associated RFH?

[robwu, 2016/03/09 22:52:20]

It seems that this context menu item is context-less (at the next line,
ContextMenuParams()'s default constructor is used). This context menu is shown
at chrome://apps, so not attributing the context menu entry to the tab and/or
frame looks OK to me.

                                           content::ContextMenuParams());
   } else if (command_id == MENU_NEW_WINDOW) {
     controller()->CreateNewWindow(profile(), false);
   } else if (command_id == MENU_NEW_INCOGNITO_WINDOW) {
     controller()->CreateNewWindow(profile(), true);
   } else {
     AppContextMenu::ExecuteCommand(command_id, event_flags);
   }
 }
 
 }  // namespace app_list