Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: chrome/browser/ui/app_list/extension_app_context_menu.cc

Issue 1772513002: Add frameId to contextMenus.onClicked / onclick. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_context_menu.cc
diff --git a/chrome/browser/ui/app_list/extension_app_context_menu.cc b/chrome/browser/ui/app_list/extension_app_context_menu.cc
index 65a3a483617f78af2cf62e3f0bc9884d56f20302..39d939b680d3845d08d90965eb8b9dfeea2c2ea1 100644
--- a/chrome/browser/ui/app_list/extension_app_context_menu.cc
+++ b/chrome/browser/ui/app_list/extension_app_context_menu.cc
@@ -237,7 +237,7 @@ void ExtensionAppContextMenu::ExecuteCommand(int command_id, int event_flags) {
controller()->UninstallApp(profile(), app_id());
} else if (extensions::ContextMenuMatcher::IsExtensionsCustomCommandId(
command_id)) {
- extension_menu_items_->ExecuteCommand(command_id, nullptr,
+ extension_menu_items_->ExecuteCommand(command_id, nullptr, nullptr,
sky 2016/03/09 22:44:40 Don't extensions have an associated RFH?
robwu 2016/03/09 22:52:20 It seems that this context menu item is context-le
content::ContextMenuParams());
} else if (command_id == MENU_NEW_WINDOW) {
controller()->CreateNewWindow(profile(), false);

Powered by Google App Engine
This is Rietveld 408576698