chrome/browser/extensions/menu_manager_unittest.cc - Issue 1772513002: Add frameId to contextMenus.onClicked / onclick.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager_unittest.cc

Issue 1772513002: Add frameId to contextMenus.onClicked / onclick. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/menu_manager_unittest.cc

diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc

index 29fa6d52b3e4d5fb3f4ffb3e096b44f63bfa41c9..e22aeb6e52cbb55f894a0bf352d9afa203533243 100644

--- a/chrome/browser/extensions/menu_manager_unittest.cc

+++ b/chrome/browser/extensions/menu_manager_unittest.cc

@@ -590,7 +590,8 @@ TEST_F(MenuManagerTest, ExecuteCommand) {

.Times(1)

.WillOnce(DeleteArg<2>());

}

- manager_.ExecuteCommand(&profile, NULL /* web_contents */, params, id);

+ manager_.ExecuteCommand(&profile, nullptr /* web_contents */,

+ nullptr /* render_frame_host */, params, id);

ASSERT_EQ(2u, list->GetSize());