Web Animations: Use of hyphens is no longer supported

Web Animations: Use of hyphens is no longer supported

Hyphenated names in Web Animations keyframes were deprecated in M50.

camelCase is now required.

BUG=588025
Committed: https://crrev.com/356ff3329424333a5dd0d8f971bbee648ed5d9ad
Cr-Commit-Position: refs/heads/master@{#381541}

[Eric Willigers, 2016-03-07 01:58:02]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-03-07 03:08:52]

alancutter@chromium.org changed reviewers:
+ shans@chromium.org

[alancutter (OOO until 2018), 2016-03-07 03:08:53]

I would lean towards throwing an error/warning instead of just failing silently.
+shans, WDYT?

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js:74:

This helper function should be below the configuration variables.

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen.html
(left):

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen.html:17:
</script>
We should update this test to check that hyphenated properties are rejected.

[Eric Willigers, 2016-03-09 03:21:21]

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js:74:

On 2016/03/07 03:08:53, alancutter wrote:
> This helper function should be below the configuration variables.

Done.

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen.html
(left):

https://codereview.chromium.org/1771733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen.html:17:
</script>
On 2016/03/07 03:08:53, alancutter wrote:
> We should update this test to check that hyphenated properties are rejected.

New test added: reject-hyphen.html

[Eric Willigers, 2016-03-10 01:18:06]

On 2016/03/07 03:08:53, alancutter wrote:
> I would lean towards throwing an error/warning instead of just failing
silently.
> +shans, WDYT?
> 

Warning added.

[alancutter (OOO until 2018), 2016-03-10 01:26:50]

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html
(right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html:23: }
Why is there a try catch?

This helper function isn't needed, you could just say
element.animate({'font-size': '20px'}, {fill: 'forwards'}) directly.

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html:31: },
'Hyphenated propery names are rejected.');
s/rejected/ignored/

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp (right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:35: if
(property.find('-') != kNotFound) {
Does this logic need to move? This seems more expensive without any reason for
it.

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:360: return "Hyphenated
property naming in Web Animations keyframes is invalid and therefore ignored.
Please use camelCase instead.";
s/naming/names/
s/is/are/

[Eric Willigers, 2016-03-10 01:56:03]

ericwilligers@chromium.org changed reviewers:
+ dstockwell@chromium.org

[Eric Willigers, 2016-03-10 01:56:04]

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html
(right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html:23: }
On 2016/03/10 01:26:50, alancutter wrote:
> Why is there a try catch?
> 
> This helper function isn't needed, you could just say
> element.animate({'font-size': '20px'}, {fill: 'forwards'}) directly.

Fixed.

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html:31: },
'Hyphenated propery names are rejected.');
On 2016/03/10 01:26:50, alancutter wrote:
> s/rejected/ignored/

Done.

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp (right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:35: if
(property.find('-') != kNotFound) {
On 2016/03/10 01:26:50, alancutter wrote:
> Does this logic need to move? This seems more expensive without any reason for
> it.

Moved back.

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1771733002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:360: return "Hyphenated
property naming in Web Animations keyframes is invalid and therefore ignored.
Please use camelCase instead.";
On 2016/03/10 01:26:50, alancutter wrote:
> s/naming/names/
> s/is/are/

Done.

[alancutter (OOO until 2018), 2016-03-10 02:11:22]

lgtm

[dstockwell, 2016-03-10 02:16:25]

lgtm

[Eric Willigers, 2016-03-10 02:18:33]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:19:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/50017
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/50017

[commit-bot: I haz the power, 2016-03-10 02:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:58:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-03-10 03:29:51]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-10 03:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/50017
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/50017

[commit-bot: I haz the power, 2016-03-10 04:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 04:26:35]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-03-10 04:43:07]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-10 04:43:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/50017
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/50017

[commit-bot: I haz the power, 2016-03-10 05:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 05:42:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-03-10 13:11:35]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-03-10 13:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1771733002/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-10 13:11:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/70001

[commit-bot: I haz the power, 2016-03-10 17:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 17:06:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-03-10 20:30:41]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-10 20:32:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/70001

[commit-bot: I haz the power, 2016-03-10 23:43:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:44:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-03-11 03:29:43]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-11 03:30:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/70001

[commit-bot: I haz the power, 2016-03-11 03:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 03:48:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-03-13 22:28:27]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-03-13 22:28:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/70001

[commit-bot: I haz the power, 2016-03-14 01:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 01:34:42]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-03-16 19:47:51]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-03-16 19:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1771733002/#ps100001
(title: "Avoid Windows Release failure")

[commit-bot: I haz the power, 2016-03-16 19:48:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771733002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771733002/100001

[commit-bot: I haz the power, 2016-03-16 21:03:20]

Committed patchset #7 (id:100001)

[commit-bot: I haz the power, 2016-03-16 21:04:53]

Description was changed from

==========
Web Animations: Use of hyphens is no longer supported

Hyphenated names in Web Animations keyframes were deprecated in M50.

camelCase is now required.


BUG=588025
==========

to

==========
Web Animations: Use of hyphens is no longer supported

Hyphenated names in Web Animations keyframes were deprecated in M50.

camelCase is now required.

BUG=588025

Committed: https://crrev.com/356ff3329424333a5dd0d8f971bbee648ed5d9ad
Cr-Commit-Position: refs/heads/master@{#381541}
==========

[commit-bot: I haz the power, 2016-03-16 21:04:54]

Patchset 7 (id:??) landed as
https://crrev.com/356ff3329424333a5dd0d8f971bbee648ed5d9ad
Cr-Commit-Position: refs/heads/master@{#381541}

[foolip, 2016-11-24 09:22:16]

ericwilligers@, when do you think it would make sense to remove this deprecation
message? (I'm auditing deprecation messages with no removal date, and this
appears to be an already-removed case.)

[Eric Willigers, 2016-11-24 11:34:23]

On 2016/11/24 09:22:16, foolip wrote:
> ericwilligers@, when do you think it would make sense to remove this
deprecation
> message? (I'm auditing deprecation messages with no removal date, and this
> appears to be an already-removed case.)

I think we can remove it now. I've uploaded
https://codereview.chromium.org/2526233002