Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2526233002: Web Animations: Retire warning for hyphenated property names (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Retire warning for hyphenated property names camelCase has been required in Web Animations keyframes for at least eight months now. Committed: https://crrev.com/c73cae5e349eaaa8f3ebf8eef4ec6912fb93afdf Cr-Commit-Position: refs/heads/master@{#434597}

Patch Set 1 #

Patch Set 2 : retire deprecation warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
D third_party/WebKit/LayoutTests/animations/deprecated-hyphen.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/deprecated-hyphen-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
Eric Willigers
See conversation with foolip in https://codereview.chromium.org/1771733002
4 years ago (2016-11-25 11:42:17 UTC) #8
suzyh_UTC10 (ex-contributor)
lgtm
4 years ago (2016-11-27 23:06:33 UTC) #11
Eric Willigers
+sashab for OWNERS
4 years ago (2016-11-27 23:36:26 UTC) #13
sashab
lgtm
4 years ago (2016-11-27 23:44:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526233002/20001
4 years ago (2016-11-28 00:25:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 03:28:08 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-28 03:30:29 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c73cae5e349eaaa8f3ebf8eef4ec6912fb93afdf
Cr-Commit-Position: refs/heads/master@{#434597}

Powered by Google App Engine
This is Rietveld 408576698