third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html - Issue 1771733002: Web Animations: Use of hyphens is no longer supported

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html

Issue 1771733002: Web Animations: Use of hyphens is no longer supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: warn if hyphenated property is present Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/deprecated-hyphen-expected.txt ('k') | third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen-expected.txt » ('j') | third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <style>

	5

	6 div { font-size: 10px; }

	7

	8 </style>

	9 <div id='element'></div>

	10 <script>

	11

	12 var element = document.getElementById('element');

	13

	14 function animate(property, value) {

	15 var keyframes = [

	16 {offset: 0},

	17 {offset: 1},

	18 ];

	19 keyframes[0][property] = value;

	20 keyframes[1][property] = value;

	21

	22 try { element.animate(keyframes, {fill: 'forwards'}); } catch(e) {}

	23 }
	alancutter (OOO until 2018) 2016/03/10 01:26:50 Why is there a try catch? This helper function is Why is there a try catch? This helper function isn't needed, you could just say element.animate({'font-size': '20px'}, {fill: 'forwards'}) directly. Eric Willigers 2016/03/10 01:56:04 Fixed. Show quoted text On 2016/03/10 01:26:50, alancutter wrote: > Why is there a try catch? > > This helper function isn't needed, you could just say > element.animate({'font-size': '20px'}, {fill: 'forwards'}) directly. Fixed.
	24

	25 test(function() {

	26 animate('font-size', '20px');

	27 assert_equals(getComputedStyle(element).fontSize, '10px');

	28

	29 animate('fontSize', '30px');

	30 assert_equals(getComputedStyle(element).fontSize, '30px');

	31 }, 'Hyphenated propery names are rejected.');
	alancutter (OOO until 2018) 2016/03/10 01:26:50 s/rejected/ignored/ s/rejected/ignored/ Eric Willigers 2016/03/10 01:56:04 Done. Show quoted text On 2016/03/10 01:26:50, alancutter wrote: > s/rejected/ignored/ Done.
	32

	33 </script>

OLD	NEW