third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp - Issue 1771733002: Web Animations: Use of hyphens is no longer supported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

Issue 1771733002: Web Animations: Use of hyphens is no longer supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid Windows Release failure Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen-expected.txt ('k') | third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

index 4c79bcb8fad539034f51a033e088159a5f897b27..3d8f0549126e78275efa29703f9438fdb0dad806 100644

--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

@@ -36,10 +36,15 @@ CSSPropertyID AnimationInputHelpers::keyframeAttributeToCSSProperty(const String

return CSSPropertyInvalid;

if (property == "cssFloat")

return CSSPropertyFloat;

StringBuilder builder;

for (size_t i = 0; i < property.length(); ++i) {

- if (property[i] == '-')

- Deprecation::countDeprecation(document, UseCounter::WebAnimationHyphenatedProperty);

+ // Disallow hyphenated properties.

+ if (property[i] == '-') {

+ if (cssPropertyID(property) != CSSPropertyInvalid)

+ Deprecation::countDeprecation(document, UseCounter::WebAnimationHyphenatedProperty);

+ return CSSPropertyInvalid;

+ }

if (isASCIIUpper(property[i]))

builder.append('-');

builder.append(property[i]);