gfx::Image: Added thread checker.

gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off or temporarily disabled. Added
hand-offs / disables for known locations where images are passed to a
new thread without retaining a reference on the old thread.

BUG=600229

[Matt Giuca, 2016-03-08 08:21:07]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 08:21:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771033003/1

[commit-bot: I haz the power, 2016-03-08 08:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 08:55:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2016-04-04 04:26:49]

Description was changed from

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off. Added hand-offs for known
locations where images are passed to a new thread without retaining a
reference on the old thread.

BUG=590882
==========

to

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off. Added hand-offs for known
locations where images are passed to a new thread without retaining a
reference on the old thread.

BUG=596348
==========

[Matt Giuca, 2016-04-05 07:50:16]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 07:50:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771033003/20001

[commit-bot: I haz the power, 2016-04-05 08:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 08:26:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-04-07 05:57:13]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 05:57:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771033003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771033003/60001

[Matt Giuca, 2016-04-20 04:41:31]

Description was changed from

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off. Added hand-offs for known
locations where images are passed to a new thread without retaining a
reference on the old thread.

BUG=596348
==========

to

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off. Added hand-offs for known
locations where images are passed to a new thread without retaining a
reference on the old thread.

BUG=596348,600229
==========

[Matt Giuca, 2017-07-19 04:37:36]

Description was changed from

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off. Added hand-offs for known
locations where images are passed to a new thread without retaining a
reference on the old thread.

BUG=596348,600229
==========

to

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off or temporarily disabled. Added
hand-offs / disables for known locations where images are passed to a
new thread without retaining a reference on the old thread.

BUG=600229
==========

[Matt Giuca, 2017-07-20 05:54:45]

Description was changed from

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off or temporarily disabled. Added
hand-offs / disables for known locations where images are passed to a
new thread without retaining a reference on the old thread.

BUG=600229
==========

to

==========
gfx::Image: Added thread checker.

In Debug builds, this will check-fail if an image is used from two
threads without being properly handed off or temporarily disabled. Added
hand-offs / disables for known locations where images are passed to a
new thread without retaining a reference on the old thread.

BUG=600229
==========

[Matt Giuca, 2017-07-20 05:54:54]

I realised there is a much better way to deal with the false positives than
manually annotating each safe handoff site: https://crbug.com/600229#c5.
Abandoning in favour of https://chromium-review.googlesource.com/c/578750/.