chrome/browser/web_applications/web_app.cc - Issue 1771033003: gfx::Image: Added thread checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app.cc

Issue 1771033003: gfx::Image: Added thread checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove UpdateShortcutWorker changes; instead just disable thread checking. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_applications/web_app.cc

diff --git a/chrome/browser/web_applications/web_app.cc b/chrome/browser/web_applications/web_app.cc

index 4dc5f5351ae6405030ba01b7369e0f0af5f9987c..83b4589c9db014e426d6f511bf80b637222e8782 100644

--- a/chrome/browser/web_applications/web_app.cc

+++ b/chrome/browser/web_applications/web_app.cc

@@ -92,6 +92,7 @@ void UpdateAllShortcutsForShortcutInfo(

const base::Closure& callback,

std::unique_ptr<web_app::ShortcutInfo> shortcut_info) {

base::FilePath shortcut_data_dir = GetShortcutDataDir(*shortcut_info);

+ shortcut_info->favicon.DetachFromThread();

web_app::ShortcutInfo::PostIOTaskAndReply(

base::BindOnce(&web_app::internals::UpdatePlatformShortcuts,

shortcut_data_dir, old_app_title),

@@ -127,6 +128,7 @@ void ScheduleCreatePlatformShortcut(

const web_app::ShortcutLocations& locations,

std::unique_ptr<web_app::ShortcutInfo> shortcut_info) {

base::FilePath shortcut_data_dir = GetShortcutDataDir(*shortcut_info);

+ shortcut_info->favicon.DetachFromThread();

web_app::ShortcutInfo::PostIOTask(

base::BindOnce(

base::IgnoreResult(&web_app::internals::CreatePlatformShortcuts),