Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7806)

Unified Diff: chrome/browser/themes/browser_theme_pack.h

Issue 1771033003: gfx::Image: Added thread checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove UpdateShortcutWorker changes; instead just disable thread checking. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_info_cache.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/browser_theme_pack.h
diff --git a/chrome/browser/themes/browser_theme_pack.h b/chrome/browser/themes/browser_theme_pack.h
index adb608c78340019ca8dbf247c82a55a971cf17fb..3aa4f92663aab374d7a82646e1c62aaeaf2c39ab 100644
--- a/chrome/browser/themes/browser_theme_pack.h
+++ b/chrome/browser/themes/browser_theme_pack.h
@@ -261,9 +261,13 @@ class BrowserThemePack : public CustomThemeSupplier {
ImageCache images_;
// Cache of images created in BuildFromExtension(). Once the theme pack is
- // created, this cache should only be accessed on the file thread. There
- // should be no IDs in |image_memory_| that are in |images_on_file_thread_|
- // or vice versa.
+ // created, this cache should only be accessed on the FILE thread (or whatever
+ // thread WriteToDisk is called from*). There should be no IDs in
+ // |image_memory_| that are in |images_on_file_thread_| or vice versa.
+ //
+ // *NOTE: These are usually accessed on the FILE thread, but as the
+ // documentation for WriteToDisk notes, it is not always the FILE thread; just
+ // some thread other than UI.
ImageCache images_on_file_thread_;
// Whether the theme pack has been succesfully initialized and is ready to
« no previous file with comments | « chrome/browser/profiles/profile_info_cache.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698