Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1980)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/web_applications/web_app_win.cc

Issue 1771033003: gfx::Image: Added thread checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove UpdateShortcutWorker changes; instead just disable thread checking. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_applications/web_app.cc ('k') | ui/gfx/image/image.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_win.cc
diff --git a/chrome/browser/web_applications/web_app_win.cc b/chrome/browser/web_applications/web_app_win.cc
index 0b6ee7b17dd7676baefc1808671b436a998a6fd6..de2ff25d3f5f8ac03a44683179f2f998aa13e606 100644
--- a/chrome/browser/web_applications/web_app_win.cc
+++ b/chrome/browser/web_applications/web_app_win.cc
@@ -371,6 +371,9 @@ void OnShortcutInfoLoadedForSetRelaunchDetails(
base::FilePath icon_file =
web_app::internals::GetIconFilePath(web_app_path, shortcut_info->title);
+ // |shortcut_info->favicon| is not shared outside of this function, and needs
+ // to be used on another thread.
+ shortcut_info->favicon.DetachFromThread();
web_app::ShortcutInfo::PostIOTask(
base::BindOnce(&CreateIconAndSetRelaunchDetails, web_app_path, icon_file,
hwnd),
« no previous file with comments | « chrome/browser/web_applications/web_app.cc ('k') | ui/gfx/image/image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698