Make CACHE_DIR set by default in most gclient configs.

Make CACHE_DIR set by default in most gclient configs.

This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299143

[martiniss, 2016-03-08 01:56:33]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org, szager@chromium.org

[martiniss, 2016-03-08 01:56:34]

PTAL

[szager1, 2016-03-08 02:24:44]

https://codereview.chromium.org/1768893003/diff/1/recipe_modules/gclient/api.py
File recipe_modules/gclient/api.py (right):

https://codereview.chromium.org/1768893003/diff/1/recipe_modules/gclient/api....
recipe_modules/gclient/api.py:131: 'CACHE_DIR': self.m.path['git_cache'],
Is this a static default path?

https://codereview.chromium.org/1768893003/diff/1/recipe_modules/gclient/conf...
File recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/1768893003/diff/1/recipe_modules/gclient/conf...
recipe_modules/gclient/config.py:17: cache_dir = str(CACHE_DIR) if CACHE_DIR
else None
If I'm understanding this right, this is the actual fix, right?  I believe this
will also modify the deps_file gclient spec field, right?  Any concern about
that?

[iannucci, 2016-03-08 04:09:40]

this lgtm. I assume you've simulated it downstream to see the effect?

https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
File recipe_modules/gclient/api.py (right):

https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
recipe_modules/gclient/api.py:131: 'CACHE_DIR': self.m.path['git_cache'],
On 2016/03/08 at 02:24:43, szager1 wrote:
> Is this a static default path?

this is
https://github.com/luci/recipes-py/blob/master/recipe_modules/path/config.py#L40

https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
File recipe_modules/gclient/config.py (right):

https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
recipe_modules/gclient/config.py:17: cache_dir = str(CACHE_DIR) if CACHE_DIR
else None
On 2016/03/08 at 02:24:43, szager1 wrote:
> If I'm understanding this right, this is the actual fix, right?  I believe
this will also modify the deps_file gclient spec field, right?  Any concern
about that?

It will modify it at the base of the config tree: anything else from here to the
recipe can override it.

[martiniss, 2016-03-08 06:00:18]

On 2016/03/08 at 04:09:40, iannucci wrote:
> this lgtm. I assume you've simulated it downstream to see the effect?
> 
>
https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
> File recipe_modules/gclient/api.py (right):
> 
>
https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
> recipe_modules/gclient/api.py:131: 'CACHE_DIR': self.m.path['git_cache'],
> On 2016/03/08 at 02:24:43, szager1 wrote:
> > Is this a static default path?
> 
> this is
https://github.com/luci/recipes-py/blob/master/recipe_modules/path/config.py#L40
> 
>
https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
> File recipe_modules/gclient/config.py (right):
> 
>
https://chromiumcodereview.appspot.com/1768893003/diff/1/recipe_modules/gclie...
> recipe_modules/gclient/config.py:17: cache_dir = str(CACHE_DIR) if CACHE_DIR
else None
> On 2016/03/08 at 02:24:43, szager1 wrote:
> > If I'm understanding this right, this is the actual fix, right?  I believe
this will also modify the deps_file gclient spec field, right?  Any concern
about that?
> 
> It will modify it at the base of the config tree: anything else from here to
the recipe can override it.

talked to szager over dinner, and he informal LGTM-ed it offline :) 

Tested on my computer and its the same spec change. Will manually roll.

[martiniss, 2016-03-08 06:00:22]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-03-08 06:00:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768893003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768893003/1

[commit-bot: I haz the power, 2016-03-08 06:02:54]

Description was changed from

==========
Make CACHE_DIR set by default in most gclient configs.

This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140
==========

to

==========
Make CACHE_DIR set by default in most gclient configs.

This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299143
==========

[commit-bot: I haz the power, 2016-03-08 06:02:55]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299143

[borenet, 2016-03-08 15:28:09]

On 2016/03/08 06:02:55, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299143

This CL seems to have broken all Skia bots.  Is there a way around this?  Or,
can we revert this until fixed?  Eg.
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-G...

[borenet, 2016-03-08 16:28:11]

On 2016/03/08 15:28:09, borenet wrote:
> On 2016/03/08 06:02:55, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=299143
> 
> This CL seems to have broken all Skia bots.  Is there a way around this?  Or,
> can we revert this until fixed?  Eg.
>
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-G...

I was able to fix by switching Skia bots to unmanaged mode.

[iannucci, 2016-03-08 17:20:11]

Managed mode rears its head again :( I thought that we removed managed
mode. Too many partial cleanups :(

Are your bots using bot update, or are they directly using gclient?

On Tue, Mar 8, 2016, 08:28 <borenet@google.com> wrote:

> On 2016/03/08 15:28:09, borenet wrote:
> > On 2016/03/08 06:02:55, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > > http://src.chromium.org/viewvc/chrome?view=rev&revision=299143
> >
> > This CL seems to have broken all Skia bots. Is there a way around this?
> Or,
> > can we revert this until fixed? Eg.
> >
>
>
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-G...
>
> I was able to fix by switching Skia bots to unmanaged mode.
>
> https://codereview.chromium.org/1768893003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.