Make CACHE_DIR set by default in most gclient configs.

recipe_modules/gclient/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 
 
 class RevisionResolver(object):
   """Resolves the revision based on build properties."""
 
@@ skipping 108 matching lines @@
 
   @spec_alias.setter
   def spec_alias(self, name):
     self._spec_alias = name
 
   @spec_alias.deleter
   def spec_alias(self):
     self._spec_alias = None
 
   def get_config_defaults(self):
-    ret = {
-      'USE_MIRROR': self.use_mirror
+    return {
+      'USE_MIRROR': self.use_mirror,
+      'CACHE_DIR': self.m.path['git_cache'],

[szager1, 2016/03/08 02:24:43]

Is this a static default path?

[iannucci, 2016/03/08 04:09:40]

this is
https://github.com/luci/recipes-py/blob/master/recipe_modules/path/config.py#L40

     }
-    ret['CACHE_DIR'] = self.m.path['root'].join('git_cache')
-    return ret
 
   def resolve_revision(self, revision):
     if hasattr(revision, 'resolve'):
       return revision.resolve(self.m.properties)
     return revision
 
   def sync(self, cfg, with_branch_heads=False, **kwargs):
     revisions = []
     for i, s in enumerate(cfg.solutions):
       if s.safesync_url:  # prefer safesync_url in gclient mode
@@ skipping 178 matching lines @@
           for (path, dir, files) in os.walk(build_path):
             for cur_file in files:
               if cur_file.endswith('index.lock'):
                 path_to_file = os.path.join(path, cur_file)
                 print 'deleting %s' % path_to_file
                 os.remove(path_to_file)
       """,
       args=[self.m.path['slave_build']],
       infra_step=True,
     )