Make CACHE_DIR set by default in most gclient configs.

recipe_modules/gclient/api.py

Index: recipe_modules/gclient/api.py
diff --git a/recipe_modules/gclient/api.py b/recipe_modules/gclient/api.py
index 1b705d5b35d28efa7ce15cc73361cdfda960e24e..98100c2058877b8af3f049399dd605455b8c2c8f 100644
--- a/recipe_modules/gclient/api.py
+++ b/recipe_modules/gclient/api.py
@@ -126,11 +126,10 @@ class GclientApi(recipe_api.RecipeApi):
     self._spec_alias = None
 
   def get_config_defaults(self):
-    ret = {
-      'USE_MIRROR': self.use_mirror
+    return {
+      'USE_MIRROR': self.use_mirror,
+      'CACHE_DIR': self.m.path['git_cache'],

[szager1, 2016/03/08 02:24:43]

Is this a static default path?

[iannucci, 2016/03/08 04:09:40]

this is
https://github.com/luci/recipes-py/blob/master/recipe_modules/path/config.py#L40

     }
-    ret['CACHE_DIR'] = self.m.path['root'].join('git_cache')
-    return ret
 
   def resolve_revision(self, revision):
     if hasattr(revision, 'resolve'):