recipe_modules/gclient/config.py - Issue 1768893003: Make CACHE_DIR set by default in most gclient configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/gclient/config.py

Issue 1768893003: Make CACHE_DIR set by default in most gclient configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/gclient/config.py

diff --git a/recipe_modules/gclient/config.py b/recipe_modules/gclient/config.py

index b8152734b11bf7d14fdc6d71af65103a2719b4d7..c300edd506d54e52808063ac576d6ba3c322bcbe 100644

--- a/recipe_modules/gclient/config.py

+++ b/recipe_modules/gclient/config.py

@@ -14,7 +14,7 @@ def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None,

PATCH_PROJECT=None, BUILDSPEC_VERSION=None,

**_kwargs):

deps = '.DEPS.git' if GIT_MODE else 'DEPS'

- cache_dir = str(CACHE_DIR) if GIT_MODE and CACHE_DIR else None

+ cache_dir = str(CACHE_DIR) if CACHE_DIR else None

szager1 2016/03/08 02:24:43 If I'm understanding this right, this is the actua

iannucci 2016/03/08 04:09:40 It will modify it at the base of the config tree:

return ConfigGroup(

solutions = ConfigList(

lambda: ConfigGroup(

« recipe_modules/gclient/api.py ('K') | « recipe_modules/gclient/api.py ('k') | recipe_modules/gclient/example.expected/basic.json » ('j') | no next file with comments »