Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1766723004: style: Remame values in EOverflow and EVerticalAlign to CamelCase (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
pdr., chrishtr
CC:
chrishtr, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dshwang, krit, eae+blinkwatch, Eric Willigers, esprehn, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr., pdr+renderingwatchlist_chromium.org, piman, rjwright, rwlbuis, Stephen Chennney, shans, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, Nico, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

style: Remame values in EOverflow and EVerticalAlign to CamelCase And prefix them to make them unique. Renames a method to add get- prefix that collides with an enum value now. R=pdr BUG=584539 Committed: https://crrev.com/b29bcaa4828dbc9d63eaf0c3b7c808f27fea71f3 Cr-Commit-Position: refs/heads/master@{#379679}

Patch Set 1 #

Patch Set 2 : enum-clash-EOverflowEVerticalAlign: rebase #

Patch Set 3 : enum-clash-EOverflowEVerticalAlign: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -176 lines) Patch
M third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 4 chunks +35 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 5 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
danakj
4 years, 9 months ago (2016-03-05 01:17:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723004/1
4 years, 9 months ago (2016-03-05 01:17:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/140734) mac_chromium_rel_ng on ...
4 years, 9 months ago (2016-03-05 01:20:49 UTC) #5
chrishtr
lgtm
4 years, 9 months ago (2016-03-05 01:23:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723004/1
4 years, 9 months ago (2016-03-05 01:36:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/140741) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-05 01:40:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723004/20001
4 years, 9 months ago (2016-03-05 01:50:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/125948)
4 years, 9 months ago (2016-03-05 01:59:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723004/40001
4 years, 9 months ago (2016-03-07 22:00:40 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 23:20:35 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 23:21:41 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b29bcaa4828dbc9d63eaf0c3b7c808f27fea71f3
Cr-Commit-Position: refs/heads/master@{#379679}

Powered by Google App Engine
This is Rietveld 408576698