third_party/WebKit/Source/core/layout/TextAutosizer.cpp - Issue 1766723004: style: Remame values in EOverflow and EVerticalAlign to CamelCase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/TextAutosizer.cpp

Issue 1766723004: style: Remame values in EOverflow and EVerticalAlign to CamelCase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enum-clash-EOverflowEVerticalAlign: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/TextAutosizer.cpp

diff --git a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

index 02aa2ecebfee008d8c1f002e5d6484bb8d5d992e..cf41bf8a6fb9d3c009af4077934419314f087030 100644

--- a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

+++ b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

@@ -225,7 +225,7 @@ static bool blockHeightConstrained(const LayoutBlock* block)

// FIXME: Consider additional heuristics, such as ignoring fixed heights if the content is already overflowing before autosizing kicks in.

for (; block; block = block->containingBlock()) {

const ComputedStyle& style = block->styleRef();

- if (style.overflowY() >= OSCROLL)

+ if (style.overflowY() >= OverflowScroll)

return false;

if (style.height().isSpecified() || style.maxHeight().isSpecified() || block->isOutOfFlowPositioned()) {

// Some sites (e.g. wikipedia) set their html and/or body elements to height:100%,