third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1766723004: style: Remame values in EOverflow and EVerticalAlign to CamelCase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1766723004: style: Remame values in EOverflow and EVerticalAlign to CamelCase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enum-clash-EOverflowEVerticalAlign: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index b067ecad0efff31bb8e6ac176ca999fc365f2709..c1337bf4f95bc6be3b35ab2289d0d64ac0303b4c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -209,8 +209,8 @@ void LayoutInline::updateAlwaysCreateLineBoxes(bool fullLayout)

LayoutInline* parentLayoutInline = parent()->isLayoutInline() ? toLayoutInline(parent()) : 0;

bool checkFonts = document().inNoQuirksMode();

bool alwaysCreateLineBoxesNew = (parentLayoutInline && parentLayoutInline->alwaysCreateLineBoxes())

- || (parentLayoutInline && parentStyle.verticalAlign() != BASELINE)

- || style()->verticalAlign() != BASELINE

+ || (parentLayoutInline && parentStyle.verticalAlign() != VerticalAlignBaseline)

+ || style()->verticalAlign() != VerticalAlignBaseline

|| style()->getTextEmphasisMark() != TextEmphasisMarkNone

|| (checkFonts && (!parentStyle.font().fontMetrics().hasIdenticalAscentDescentAndLineGap(style()->font().fontMetrics())

|| parentStyle.lineHeight() != style()->lineHeight()));

@@ -220,7 +220,7 @@ void LayoutInline::updateAlwaysCreateLineBoxes(bool fullLayout)

const ComputedStyle& firstLineParentStyle = parent()->styleRef(true);

const ComputedStyle& childStyle = styleRef(true);

alwaysCreateLineBoxesNew = !firstLineParentStyle.font().fontMetrics().hasIdenticalAscentDescentAndLineGap(childStyle.font().fontMetrics())

- || childStyle.verticalAlign() != BASELINE

+ || childStyle.verticalAlign() != VerticalAlignBaseline

|| firstLineParentStyle.lineHeight() != childStyle.lineHeight();

}