style: Rename the PseudoId enum values to CamelCase and prefix them.

style: Rename the PseudoId enum values to CamelCase and prefix them.

R=pdr
BUG=584539
Committed: https://crrev.com/55d0a18194e3abe3ef52f48f021fa677c4803153
Cr-Commit-Position: refs/heads/master@{#379909}

[danakj, 2016-03-04 23:22:24]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-04 23:23:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765933003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765933003/1

[commit-bot: I haz the power, 2016-03-04 23:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 23:23:07]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[danakj, 2016-03-05 01:32:08]

pingeroonie, just in case this gets lost, as there were lots of patches.

[pdr., 2016-03-07 23:34:03]

pdr@chromium.org changed reviewers:
+ esprehn@chromium.org

[pdr., 2016-03-07 23:34:03]

The codechange here looks fine but I worry the names might regress
understandability. This isn't really your fault but we have styleType()
returning pseudoIds, etc.

@esprehn, does this LGTY?

[esprehn, 2016-03-08 02:18:48]

Lgtm w/ none fixed.

https://codereview.chromium.org/1765933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp (right):

https://codereview.chromium.org/1765933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp:515: return
styledNode->ensureComputedStyle(styledNode->isPseudoElement() ? PseudoIdNoPseudo
: m_pseudoElementSpecifier);
PseudoIdNone

[danakj, 2016-03-08 18:30:15]

d

https://codereview.chromium.org/1765933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp (right):

https://codereview.chromium.org/1765933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp:515: return
styledNode->ensureComputedStyle(styledNode->isPseudoElement() ? PseudoIdNoPseudo
: m_pseudoElementSpecifier);
On 2016/03/08 02:18:48, esprehn wrote:
> PseudoIdNone

Done.

[danakj, 2016-03-08 18:31:03]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-08 18:31:04]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1765933003/#ps60001
(title: "enum-clash-PseudoId: none")

[commit-bot: I haz the power, 2016-03-08 18:31:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765933003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765933003/60001

[commit-bot: I haz the power, 2016-03-08 21:33:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-08 21:34:20]

Description was changed from

==========
style: Rename the PseudoId enum values to CamelCase and prefix them.

R=pdr
BUG=584539
==========

to

==========
style: Rename the PseudoId enum values to CamelCase and prefix them.

R=pdr
BUG=584539

Committed: https://crrev.com/55d0a18194e3abe3ef52f48f021fa677c4803153
Cr-Commit-Position: refs/heads/master@{#379909}
==========

[commit-bot: I haz the power, 2016-03-08 21:34:22]

Patchset 4 (id:??) landed as
https://crrev.com/55d0a18194e3abe3ef52f48f021fa677c4803153
Cr-Commit-Position: refs/heads/master@{#379909}