Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Issue 1765933003: style: Rename the PseudoId enum values to CamelCase and prefix them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enum-clash-PseudoId: none Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
index 3ab8be78c370b5ee25d441453451f33367a6a434..8e03c3ddb2f4fbe026a91a4c0f737b2059e56c8e 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
@@ -58,15 +58,29 @@ enum PrintColorAdjust {
enum PseudoId {
// The order must be NOP ID, public IDs, and then internal IDs.
// If you add or remove a public ID, you must update _pseudoBits in ComputedStyle.
- NOPSEUDO, FIRST_LINE, FIRST_LETTER, BEFORE, AFTER, BACKDROP, SELECTION, FIRST_LINE_INHERITED, SCROLLBAR,
+ PseudoIdNone,
+ PseudoIdFirstLine,
+ PseudoIdFirstLetter,
+ PseudoIdBefore,
+ PseudoIdAfter,
+ PseudoIdBackdrop,
+ PseudoIdSelection,
+ PseudoIdFirstLineInherited,
+ PseudoIdScrollbar,
// Internal IDs follow:
- SCROLLBAR_THUMB, SCROLLBAR_BUTTON, SCROLLBAR_TRACK, SCROLLBAR_TRACK_PIECE, SCROLLBAR_CORNER, RESIZER, INPUT_LIST_BUTTON,
+ PseudoIdScrollbarThumb,
+ PseudoIdScrollbarButton,
+ PseudoIdScrollbarTrack,
+ PseudoIdScrollbarTrackPiece,
+ PseudoIdScrollbarCorner,
+ PseudoIdResizer,
+ PseudoIdInputListButton,
// Special values follow:
- AFTER_LAST_INTERNAL_PSEUDOID,
- FIRST_PUBLIC_PSEUDOID = FIRST_LINE,
- FIRST_INTERNAL_PSEUDOID = SCROLLBAR_THUMB,
- PUBLIC_PSEUDOID_MASK = ((1 << FIRST_INTERNAL_PSEUDOID) - 1) & ~((1 << FIRST_PUBLIC_PSEUDOID) - 1),
- PSEUDO_ELEMENT_MASK = (1 << (BEFORE - 1)) | (1 << (AFTER - 1)) | (1 << (BACKDROP - 1))
+ AfterLastInternalPseudoId,
+ FirstPublicPseudoId = PseudoIdFirstLine,
+ FirstInternalPseudoId = PseudoIdScrollbarThumb,
+ PublicPseudoIdMask = ((1 << FirstInternalPseudoId) - 1) & ~((1 << FirstPublicPseudoId) - 1),
+ ElementPseudoIdMask = (1 << (PseudoIdBefore - 1)) | (1 << (PseudoIdAfter - 1)) | (1 << (PseudoIdBackdrop - 1))
};
enum ColumnFill { ColumnFillBalance, ColumnFillAuto };
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698