Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: third_party/WebKit/Source/core/dom/PseudoElement.cpp

Issue 1765933003: style: Rename the PseudoId enum values to CamelCase and prefix them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enum-clash-PseudoId: none Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/PseudoElement.cpp
diff --git a/third_party/WebKit/Source/core/dom/PseudoElement.cpp b/third_party/WebKit/Source/core/dom/PseudoElement.cpp
index df7043ea4e6ddd64ed8426b095276f7ee6d7444a..6bcd3a64d163abe3f38f0830342d79da8788e241 100644
--- a/third_party/WebKit/Source/core/dom/PseudoElement.cpp
+++ b/third_party/WebKit/Source/core/dom/PseudoElement.cpp
@@ -43,19 +43,19 @@ PassRefPtrWillBeRawPtr<PseudoElement> PseudoElement::create(Element* parent, Pse
const QualifiedName& pseudoElementTagName(PseudoId pseudoId)
{
switch (pseudoId) {
- case AFTER: {
+ case PseudoIdAfter: {
DEFINE_STATIC_LOCAL(QualifiedName, after, (nullAtom, "<pseudo:after>", nullAtom));
return after;
}
- case BEFORE: {
+ case PseudoIdBefore: {
DEFINE_STATIC_LOCAL(QualifiedName, before, (nullAtom, "<pseudo:before>", nullAtom));
return before;
}
- case BACKDROP: {
+ case PseudoIdBackdrop: {
DEFINE_STATIC_LOCAL(QualifiedName, backdrop, (nullAtom, "<pseudo:backdrop>", nullAtom));
return backdrop;
}
- case FIRST_LETTER: {
+ case PseudoIdFirstLetter: {
DEFINE_STATIC_LOCAL(QualifiedName, firstLetter, (nullAtom, "<pseudo:first-letter>", nullAtom));
return firstLetter;
}
@@ -72,9 +72,9 @@ String PseudoElement::pseudoElementNameForEvents(PseudoId pseudoId)
DEFINE_STATIC_LOCAL(const String, after, ("::after"));
DEFINE_STATIC_LOCAL(const String, before, ("::before"));
switch (pseudoId) {
- case AFTER:
+ case PseudoIdAfter:
return after;
- case BEFORE:
+ case PseudoIdBefore:
return before;
default:
return emptyString();
@@ -85,11 +85,11 @@ PseudoElement::PseudoElement(Element* parent, PseudoId pseudoId)
: Element(pseudoElementTagName(pseudoId), &parent->document(), CreateElement)
, m_pseudoId(pseudoId)
{
- ASSERT(pseudoId != NOPSEUDO);
+ ASSERT(pseudoId != PseudoIdNone);
parent->treeScope().adoptIfNeeded(*this);
setParentOrShadowHostNode(parent);
setHasCustomStyleCallbacks();
- if ((pseudoId == BEFORE || pseudoId == AFTER) && parent->hasTagName(HTMLNames::inputTag))
+ if ((pseudoId == PseudoIdBefore || pseudoId == PseudoIdAfter) && parent->hasTagName(HTMLNames::inputTag))
UseCounter::count(parent->document(), UseCounter::PseudoBeforeAfterForInputElement);
}
@@ -125,7 +125,7 @@ void PseudoElement::attach(const AttachContext& context)
return;
ComputedStyle& style = layoutObject->mutableStyleRef();
- if (style.styleType() != BEFORE && style.styleType() != AFTER)
+ if (style.styleType() != PseudoIdBefore && style.styleType() != PseudoIdAfter)
return;
ASSERT(style.contentData());
@@ -177,7 +177,7 @@ Node* PseudoElement::findAssociatedNode() const
// The ::backdrop element is parented to the LayoutView, not to the node
// that it's associated with. We need to make sure ::backdrop sends the
// events to the parent node correctly.
- if (getPseudoId() == BACKDROP)
+ if (getPseudoId() == PseudoIdBackdrop)
return parentOrShadowHostNode();
ASSERT(layoutObject());
« no previous file with comments | « third_party/WebKit/Source/core/dom/PseudoElement.h ('k') | third_party/WebKit/Source/core/events/EventPathTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698