third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp - Issue 1765933003: style: Rename the PseudoId enum values to CamelCase and prefix them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

Issue 1765933003: style: Rename the PseudoId enum values to CamelCase and prefix them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enum-clash-PseudoId: none Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

index b587656e86dc5a1afbba46388dcbed2f0db77131..fe1bb13ff50fee7f66b8eb0042bf9b5c2d8f6846 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

@@ -189,9 +189,9 @@ PassOwnPtr<protocol::DictionaryValue> buildElementInfo(Element* element)

}

if (pseudoElement) {

- if (pseudoElement->getPseudoId() == BEFORE)

+ if (pseudoElement->getPseudoId() == PseudoIdBefore)

classNames.appendLiteral("::before");

- else if (pseudoElement->getPseudoId() == AFTER)

+ else if (pseudoElement->getPseudoId() == PseudoIdAfter)

classNames.appendLiteral("::after");

}

if (!classNames.isEmpty())