Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1765603002: Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of t… (Closed)

Created:
4 years, 9 months ago by Ryan Hamilton
Modified:
4 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of the client hello. This will allow the QUIC whitelist in Chrome to be removed. Merge internal change: 115261503 Committed: https://crrev.com/28f6469d16c75ae1ba112a3081f1eba4d383cd13 Cr-Commit-Position: refs/heads/master@{#380904}

Patch Set 1 #

Patch Set 2 : iOS #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -134 lines) Patch
M net/http/http_stream_factory_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 7 chunks +15 lines, -7 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source.h View 3 chunks +11 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_source_chromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source_chromium_nss.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source_chromium_openssl.cc View 2 chunks +37 lines, -12 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 8 chunks +86 lines, -47 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 1 2 8 chunks +29 lines, -6 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 8 chunks +22 lines, -15 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 7 chunks +7 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 14 chunks +22 lines, -7 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +18 lines, -13 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 7 chunks +10 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765603002/40001
4 years, 9 months ago (2016-03-13 00:26:10 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-13 00:26:12 UTC) #4
Ryan Hamilton
4 years, 9 months ago (2016-03-13 00:50:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765603002/40001
4 years, 9 months ago (2016-03-13 00:50:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-13 02:10:56 UTC) #10
ramant (doing other things)
lgtm
4 years, 9 months ago (2016-03-13 20:03:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765603002/40001
4 years, 9 months ago (2016-03-13 21:08:00 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-13 21:13:17 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 21:14:22 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28f6469d16c75ae1ba112a3081f1eba4d383cd13
Cr-Commit-Position: refs/heads/master@{#380904}

Powered by Google App Engine
This is Rietveld 408576698