Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 1765603002: Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of t… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_client_stream.h ('k') | net/quic/quic_crypto_client_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index 3e52079f399c45730c154fa9c46e6c5dabee0ce4..09bbaea4317a78c6cb936d342e3747d4f839d1d2 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -15,6 +15,7 @@
#include "net/quic/quic_flags.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/quic_session.h"
+#include "net/quic/quic_utils.h"
using std::string;
using std::vector;
@@ -183,8 +184,8 @@ void QuicCryptoClientStream::HandleServerConfigUpdateMessage(
crypto_config_->LookupOrCreate(server_id_);
QuicErrorCode error = crypto_config_->ProcessServerConfigUpdate(
server_config_update, session()->connection()->clock()->WallNow(),
- session()->connection()->version(), cached, &crypto_negotiated_params_,
- &error_details);
+ session()->connection()->version(), cached->chlo_hash(), cached,
+ &crypto_negotiated_params_, &error_details);
if (error != QUIC_NO_ERROR) {
CloseConnectionWithDetails(
@@ -260,6 +261,7 @@ void QuicCryptoClientStream::DoInitialize(
DCHECK(crypto_config_->proof_verifier());
// Track proof verification time when cached server config is used.
proof_verify_start_time_ = base::TimeTicks::Now();
+ chlo_hash_ = cached->chlo_hash();
// If the cached state needs to be verified, do it now.
next_state_ = STATE_VERIFY_PROOF;
} else {
@@ -328,6 +330,7 @@ void QuicCryptoClientStream::DoSendCHLO(
out.set_minimum_size(
static_cast<size_t>(max_packet_size - kFramingOverhead));
next_state_ = STATE_RECV_REJ;
+ CryptoUtils::HashHandshakeMessage(out, &chlo_hash_);
SendHandshakeMessage(out);
return;
}
@@ -355,6 +358,7 @@ void QuicCryptoClientStream::DoSendCHLO(
CloseConnectionWithDetails(error, error_details);
return;
}
+ CryptoUtils::HashHandshakeMessage(out, &chlo_hash_);
channel_id_sent_ = (channel_id_key_.get() != nullptr);
if (cached->proof_verify_details()) {
proof_handler_->OnProofVerifyDetailsAvailable(
@@ -424,8 +428,8 @@ void QuicCryptoClientStream::DoReceiveREJ(
string error_details;
QuicErrorCode error = crypto_config_->ProcessRejection(
*in, session()->connection()->clock()->WallNow(),
- session()->connection()->version(), cached, &crypto_negotiated_params_,
- &error_details);
+ session()->connection()->version(), chlo_hash_, cached,
+ &crypto_negotiated_params_, &error_details);
if (error != QUIC_NO_ERROR) {
next_state_ = STATE_NONE;
@@ -459,7 +463,8 @@ QuicAsyncStatus QuicCryptoClientStream::DoVerifyProof(
verify_ok_ = false;
QuicAsyncStatus status = verifier->VerifyProof(
- server_id_.host(), cached->server_config(), cached->certs(),
+ server_id_.host(), cached->server_config(),
+ session()->connection()->version(), chlo_hash_, cached->certs(),
cached->cert_sct(), cached->signature(), verify_context_.get(),
&verify_error_details_, &verify_details_, proof_verify_callback);
« no previous file with comments | « net/quic/quic_crypto_client_stream.h ('k') | net/quic/quic_crypto_client_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698