Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Unified Diff: net/quic/crypto/crypto_server_test.cc

Issue 1765603002: Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of t… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_protocol.h ('k') | net/quic/crypto/crypto_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/crypto_server_test.cc
diff --git a/net/quic/crypto/crypto_server_test.cc b/net/quic/crypto/crypto_server_test.cc
index 8c0e3ee1e5d997115e3f66a184502fce07634114..6e7067cb7b7e35ae66bbac1382bd2011fc48a042 100644
--- a/net/quic/crypto/crypto_server_test.cc
+++ b/net/quic/crypto/crypto_server_test.cc
@@ -199,6 +199,8 @@ class CryptoServerTest : public ::testing::TestWithParam<TestParams> {
StringPiece scid;
ASSERT_TRUE(server_config_->GetStringPiece(kSCID, &scid));
scid_hex_ = "#" + base::HexEncode(scid.data(), scid.size());
+ crypto_proof_ = QuicCryptoProof();
+ DCHECK(crypto_proof_.chain.get() == nullptr);
}
// Helper used to accept the result of ValidateClientHello and pass
@@ -377,8 +379,8 @@ class CryptoServerTest : public ::testing::TestWithParam<TestParams> {
string cert_sct;
scoped_ptr<ProofSource> proof_source(
CryptoTestUtils::ProofSourceForTesting());
- if (!proof_source->GetProof(server_ip, "", "", false, &chain, &sig,
- &cert_sct) ||
+ if (!proof_source->GetProof(server_ip, "", "", client_version_, "", false,
+ &chain, &sig, &cert_sct) ||
chain->certs.empty()) {
return "#0100000000000000";
}
@@ -737,6 +739,7 @@ TEST_P(CryptoServerTest, CorruptMultipleTags) {
"#004b5453", (string(1, 'X') + srct_hex_).c_str(),
"PUBS", pub_hex_.c_str(),
"NONC", (string(1, 'X') + nonce_hex_).c_str(),
+ "NONP", (string(1, 'X') + nonce_hex_).c_str(),
"SNO\0", (string(1, 'X') + nonce_hex_).c_str(),
"XLCT", XlctHexString().c_str(),
"VER\0", client_version_string_.c_str(),
@@ -746,7 +749,7 @@ TEST_P(CryptoServerTest, CorruptMultipleTags) {
ShouldSucceed(msg);
CheckRejectTag();
- if (client_version_ <= QUIC_VERSION_30) {
+ if (client_version_ <= QUIC_VERSION_31) {
const HandshakeFailureReason kRejectReasons[] = {
SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE, CLIENT_NONCE_INVALID_FAILURE,
SERVER_NONCE_DECRYPTION_FAILURE};
@@ -813,6 +816,7 @@ TEST_P(CryptoServerTest, NoServerNonce) {
"#004b5453", srct_hex_.c_str(),
"PUBS", pub_hex_.c_str(),
"NONC", nonce_hex_.c_str(),
+ "NONP", nonce_hex_.c_str(),
"XLCT", XlctHexString().c_str(),
"VER\0", client_version_string_.c_str(),
"$padding", static_cast<int>(kClientHelloMinimumSize),
@@ -839,6 +843,7 @@ TEST_P(CryptoServerTest, ProofForSuppliedServerConfig) {
"#004b5453", srct_hex_.c_str(),
"PUBS", pub_hex_.c_str(),
"NONC", nonce_hex_.c_str(),
+ "NONP", "123456789012345678901234567890",
"VER\0", client_version_string_.c_str(),
"XLCT", XlctHexString().c_str(),
"$padding", static_cast<int>(kClientHelloMinimumSize),
@@ -877,10 +882,13 @@ TEST_P(CryptoServerTest, ProofForSuppliedServerConfig) {
scoped_ptr<ProofVerifyDetails> details;
string error_details;
DummyProofVerifierCallback callback;
- EXPECT_EQ(QUIC_SUCCESS, proof_verifier->VerifyProof(
- "test.example.com", scfg_str.as_string(), certs,
- "", proof.as_string(), verify_context.get(),
- &error_details, &details, &callback));
+ string chlo_hash;
+ CryptoUtils::HashHandshakeMessage(msg, &chlo_hash);
+ EXPECT_EQ(QUIC_SUCCESS,
+ proof_verifier->VerifyProof(
+ "test.example.com", scfg_str.as_string(), client_version_,
+ chlo_hash, certs, "", proof.as_string(), verify_context.get(),
+ &error_details, &details, &callback));
}
TEST_P(CryptoServerTest, RejectInvalidXlct) {
« no previous file with comments | « net/quic/crypto/crypto_protocol.h ('k') | net/quic/crypto/crypto_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698